curvebs: support 512 aligned IO #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
|
cicheck |
|
cicheck |
|
cicheck |
|
cicheck |
|
cicheck |
wu-hanqing
force-pushed
the
pr-1231-2
branch
2 times, most recently
from
9a3df88
to
e848709
Compare
|
cicheck |
|
cicheck |
1 similar comment
|
cicheck |
|
cicheck |
ilixiaocui
reviewed
Jun 28, 2023
| return os; | ||
| } | ||
|
|
||
| // bool CheckFilePoolMetaWithOptions(const FilePoolOptions& options, |
src/client/service_helper.cpp
Outdated
| fi->blocksize = finfo.blocksize(); | ||
| } else { | ||
| // for backward compatibility | ||
| fi->blocksize = 4096; |
There was a problem hiding this comment.
fi->blocksize = kDefaultBlockSize?
|
cicheck |
1 similar comment
|
cicheck |
ilixiaocui
approved these changes
Jun 30, 2023
SeanHai
reviewed
Jun 30, 2023
| // chunkfile. | ||
| // Currently, we need to ensure the atomicity of the meta page update, so set | ||
| // its size to 4k. | ||
| constexpr size_t kChunkfileMetaPageSize = 4096; |
There was a problem hiding this comment.
Should metaPageSize change when block size is 512?
There was a problem hiding this comment.
meta page size is fixed, and only a tiny portion of the meta page is used to store bitmap so that we will reduce the chunk size.
| nebd::client::GetInfoResponse response; | ||
|
|
||
| request.set_fd(fd); | ||
| stub.GetInfo(cntl, &request, &response, nullptr); |
src/chunkserver/chunk_service.h
Outdated
| @@ -114,6 +114,7 @@ class ChunkServiceImpl : public ChunkService { | |||
| uint32_t maxChunkSize_; | |||
|
|
|||
| std::shared_ptr<EpochMap> epochMap_; | |||
| uint32_t align_; | |||
This reverts commit de2a121. Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>
|
cicheck |
|
cicheck |
4 similar comments
|
cicheck |
|
cicheck |
|
cicheck |
|
cicheck |
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>
|
cicheck |
1 similar comment
|
cicheck |
SeanHai
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List