[refactor]tools-v2: refactor all *map to map #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baytan0720
reviewed
Jun 20, 2023
| @@ -26,7 +26,6 @@ import ( | |||
| "fmt" | |||
| "time" | |||
|
|
|||
| "github.com/dustin/go-humanize" | |||
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
|
cicheck |
1 similar comment
|
cicheck |
|
git commit --amend -s |
|
cicheck |
Signed-off-by: XR-stb <2322882096@qq.com>
|
cicheck |
Cyber-SiKu
approved these changes
Jun 26, 2023
caoxianfei1
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2535
Problem Summary: remove the pointer of map
What is changed and how it works?
What's Changed: remove all *map from struct and function
How it Works:
The map in Golang itself is a reference type and does not need to be declared as a pointer type
Check List