Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] CurveBS: support braft lease read #2543

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[feat] CurveBS: support braft lease read #2543

merged 1 commit into from
Jul 18, 2023

Conversation

Xinlong-Chen
Copy link
Contributor

@Xinlong-Chen Xinlong-Chen commented Jun 20, 2023 •
edited

What problem does this PR solve?

Issue Number: #1598

Problem Summary: feat: support braft lease read for curvebs

What is changed and how it works?

What's Changed: enable braft lease, change request handler in chunkserver.

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@Xinlong-Chen Xinlong-Chen changed the title feat: support braft lease read for curvebs [WIP] feat: support braft lease read for curvebs Jun 20, 2023
@Xinlong-Chen Xinlong-Chen force-pushed the curvebs-lease-read branch 4 times, most recently from 53da566 to db089e4 Compare June 20, 2023 12:12
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen Xinlong-Chen force-pushed the curvebs-lease-read branch 3 times, most recently from 9d3465e to 3d01ffb Compare June 22, 2023 09:03
@SeanHai
Copy link
Contributor

SeanHai commented Jun 22, 2023

cicheck

@Xinlong-Chen Xinlong-Chen force-pushed the curvebs-lease-read branch 7 times, most recently from 7caa147 to f8a8fee Compare June 24, 2023 11:40
@Xinlong-Chen Xinlong-Chen changed the title [WIP] feat: support braft lease read for curvebs feat: support braft lease read for curvebs Jun 24, 2023
@Xinlong-Chen Xinlong-Chen force-pushed the curvebs-lease-read branch 3 times, most recently from 7d40c05 to bdc8f89 Compare June 24, 2023 11:56
@Xinlong-Chen Xinlong-Chen changed the title feat: support braft lease read for curvebs [feat] CurveBS: support braft lease read Jun 24, 2023
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

@wu-hanqing @ilixiaocui please take a look, thx~

@Xinlong-Chen Xinlong-Chen force-pushed the curvebs-lease-read branch 5 times, most recently from 928e91f to dd85ebc Compare June 28, 2023 14:25
@Xinlong-Chen Xinlong-Chen mentioned this pull request Jun 29, 2023
Merged
2 tasks
@Xinlong-Chen
Copy link
Contributor Author

cicheck

1 similar comment
@wu-hanqing
Copy link
Contributor

cicheck

@Xinlong-Chen
Copy link
Contributor Author

@ilixiaocui PTAL~ thank you~

@Xinlong-Chen Xinlong-Chen added the OSPP2023 开源之夏2023(https://summer-ospp.ac.cn) label Jul 1, 2023
ilixiaocui
ilixiaocui reviewed Jul 7, 2023
View reviewed changes
test/chunkserver/clone/op_request_test.cpp Outdated Show resolved Hide resolved
test/chunkserver/clone/op_request_test.cpp Outdated Show resolved Hide resolved
conf/chunkserver.conf Show resolved Hide resolved
src/chunkserver/copyset_node.cpp Show resolved Hide resolved
src/chunkserver/op_request.cpp Outdated Show resolved Hide resolved
test/chunkserver/clone/op_request_test.cpp Show resolved Hide resolved
@Xinlong-Chen Xinlong-Chen force-pushed the curvebs-lease-read branch 5 times, most recently from 90efdbd to 1ee3b0f Compare July 12, 2023 11:56
@Xinlong-Chen
Copy link
Contributor Author

@ilixiaocui PTAL~

Xinlong-Chen
Xinlong-Chen commented Jul 12, 2023
View reviewed changes
test/chunkserver/clone/op_request_test.cpp Show resolved Hide resolved
test/chunkserver/clone/op_request_test.cpp Show resolved Hide resolved
test/chunkserver/chunkserver_snapshot_test.cpp Show resolved Hide resolved
src/client/request_sender.cpp Show resolved Hide resolved
src/chunkserver/op_request.cpp Outdated Show resolved Hide resolved
src/chunkserver/op_request.cpp Outdated Show resolved Hide resolved
test/chunkserver/clone/op_request_test.cpp Show resolved Hide resolved
conf/chunkserver.conf Show resolved Hide resolved
test/chunkserver/clone/op_request_test.cpp Outdated Show resolved Hide resolved
test/chunkserver/clone/op_request_test.cpp Outdated Show resolved Hide resolved
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
feat: support braft lease read for curvebs
933c05a 
Signed-off-by: Xinlong Chen <xl_chen@zju.edu.cn>
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@wu-hanqing wu-hanqing merged commit 5e04407 into opencurve:master Jul 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-hanqing wu-hanqing wu-hanqing approved these changes

@ilixiaocui ilixiaocui Awaiting requested review from ilixiaocui

Assignees
No one assigned
Labels
OSPP2023 开源之夏2023(https://summer-ospp.ac.cn)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Xinlong-Chen @SeanHai @wu-hanqing @ilixiaocui