curvefs/client: fix s3 object will not be removed #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wine93
reviewed
Jun 29, 2023
wuhongsong
force-pushed
the
fix_trash_nos3
branch
from
38a0b61
to
910eae1
Compare
SeanHai
approved these changes
Jun 29, 2023
|
cicheck |
Wine93
approved these changes
Jun 29, 2023
| @@ -208,6 +208,16 @@ MetaStatusCode TrashImpl::DeleteInodeAndData(const TrashItem &item) { | |||
| clientAdaptorOption.objectPrefix = s3Info.objectprefix(); | |||
| s3Adaptor_->Reinit(clientAdaptorOption, s3Info.ak(), s3Info.sk(), | |||
| s3Info.endpoint(), s3Info.bucketname()); | |||
| ret = inodeStorage_->PaddingInodeS3ChunkInfo(item.fsId, | |||
| item.inodeId, inode.mutable_s3chunkinfomap()); | |||
wuhongsong
force-pushed
the
fix_trash_nos3
branch
from
910eae1
to
b4fd844
Compare
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When the file is deleted, the object will not be deleted forever.
the objects that will be removed is based on chunklist, now , chunklist is empty always
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List