Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] CurveFS: support braft lease read #2599

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

Xinlong-Chen
Copy link
Contributor

@Xinlong-Chen Xinlong-Chen commented Jun 30, 2023

What problem does this PR solve?

Issue Number: #1598

Problem Summary: feat: support braft lease read for curvefs

What is changed and how it works?

What's Changed: enable braft lease, change request handler in metaserver.

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@Xinlong-Chen Xinlong-Chen changed the title [feat] CurveFS: support braft lease read [WIP] [feat] CurveFS: support braft lease read Jun 30, 2023
@Xinlong-Chen Xinlong-Chen force-pushed the lease-read-curvefs branch 8 times, most recently from 70fb18a to 2fa67c8 Compare July 2, 2023 13:50
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen Xinlong-Chen changed the title [WIP] [feat] CurveFS: support braft lease read [feat] CurveFS: support braft lease read Jul 2, 2023
@Xinlong-Chen Xinlong-Chen added the OSPP2023 开源之夏2023(https://summer-ospp.ac.cn) label Jul 2, 2023
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

@wu-hanqing @ilixiaocui please take a look, thx~

@@ -208,6 +200,7 @@ class MetaCache {
RWLock rwlock4Partitions_;
PartitionInfoList partitionInfos_;
RWLock rwlock4copysetInfoMap_;
// TODO(Xinlong-Chen): delete appliedindex from CopysetInfo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will this problem be fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CopysetInfo is defined in metacache_struct.h in curvebs. If I change this struct, it will cause some ci problems, so I will fix it when prs merge. It's not difficult to do it.

#include "src/client/metacache_struct.h"

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

cicheck

@Xinlong-Chen
Copy link
Contributor Author

@ilixiaocui PTAL~

Signed-off-by: Xinlong Chen <xl_chen@zju.edu.cn>
@Xinlong-Chen
Copy link
Contributor Author

cicheck

@wu-hanqing wu-hanqing merged commit 402f237 into opencurve:master Jul 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OSPP2023 开源之夏2023(https://summer-ospp.ac.cn)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants