[feat] tools-v2: add snapshot copyset --all #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
|
@Cyber-SiKu please take a look this pr~ |
|
cicheck |
Cyber-SiKu
reviewed
Jul 10, 2023
| @@ -488,6 +488,10 @@ func AddBsAllOptionFlag(cmd *cobra.Command) { | |||
| AddBsBoolOptionFlag(cmd, CURVEBS_ALL, "all") | |||
| } | |||
|
|
|||
| func AddBsCopysetIdOptionFlag(cmd *cobra.Command) { | |||
| AddBsUint32OptionFlag(cmd, CURVEBS_COPYSET_ID, "copyset id") | |||
There was a problem hiding this comment.
option flag should be given default value
| @@ -56,65 +59,107 @@ func (sRpc *SnapshotRpc) Stub_Func(ctx context.Context) (interface{}, error) { | |||
| return sRpc.Client.Snapshot(ctx, sRpc.Request) | |||
| } | |||
|
|
|||
| type SnapshotOneCommand struct { | |||
| type SnapshotAllRpc struct { | |||
There was a problem hiding this comment.
You can split snapshotAllRpc and snapshotRpc into two commands, and then remove these two commands separately, which will make it clearer
montaguelhz
force-pushed
the
snapshot
branch
4 times, most recently
from
31c74bd
to
dd6b5b0
Compare
|
cicheck |
|
@Cyber-SiKu a big change waits for your cr. |
Xinlong-Chen
approved these changes
Jul 13, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
cicheck |
Cyber-SiKu
reviewed
Jul 13, 2023
| retErr.Format(err.Error()) | ||
| return nil, nil, retErr | ||
| } | ||
| return sCmd.TableNew, sCmd.Result, cmderror.Success() |
There was a problem hiding this comment.
You can return the response (or a map) directly instead of the table, the table has no information
| retErr.Format(err.Error()) | ||
| return nil, nil, retErr | ||
| } | ||
| return sCmd.TableNew, sCmd.Result, cmderror.Success() |
| response, err := basecmd.GetRpcResponse(sCmd.Rpc.Info, sCmd.Rpc) | ||
| sCmd.Error = err | ||
| func (sCmd *SnapshotCopysetCommand) RunCommand(cmd *cobra.Command, args []string) error { | ||
| var table, res interface{} |
There was a problem hiding this comment.
Put the processing of the result here
Signed-off-by: montaguelhz <1443171175@qq.com>
|
cicheck |
Cyber-SiKu
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2352
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
curve bs snapshot copyset --all
Side effects(Breaking backward compatibility? Performance regression?):
Check List