[feat] upgrade bs image #2629
Merged
[feat] upgrade bs image #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyber-SiKu
force-pushed
the
feat/upgreade_image_bs
branch
28 times, most recently
from
c1e6a8d
to
c103007
Compare
Closed
Cyber-SiKu
force-pushed
the
feat/upgreade_image_bs
branch
2 times, most recently
from
9c22d7b
to
6e5dca1
Compare
|
cicheck |
Cyber-SiKu
force-pushed
the
feat/upgreade_image_bs
branch
4 times, most recently
from
d517d90
to
4a45ec5
Compare
|
cicheck |
wu-hanqing
reviewed
Aug 4, 2023
| @@ -51,6 +55,22 @@ int CurveCluster::InitMdsClient(const curve::client::MetaServerOption &op) { | |||
| return mdsClient_->Initialize(op); | |||
| } | |||
|
|
|||
| std::vector<char *> VecStr2VecChar(std::vector<std::string> args) { | |||
There was a problem hiding this comment.
how about concatenating them into one string?
There was a problem hiding this comment.
how about concatenating them into one string?
will run fail
test/integration/snapshotcloneserver/snapshotcloneserver_common_test.cpp
Show resolved
Hide resolved
| @@ -35,7 +35,8 @@ server.snapshotPoolThreadNum=256 | |||
| # 快照后台线程扫描等待队列和工作队列的扫描周期(单位：ms) | |||
| server.snapshotTaskManagerScanIntervalMs=1000 | |||
| # 转储chunk分片大小 | |||
| server.chunkSplitSize=1048576 | |||
| # for nos, pls set to 1048576 | |||
| server.chunkSplitSize=8388608 | |||
There was a problem hiding this comment.
@xu-chaojie pls check this, if we change the default value, we may encounter compatible problem when upgrading existing cluster.
| @@ -57,7 +58,8 @@ server.commonPoolThreadNum=256 | |||
| # CloneTaskManager 后台线程扫描间隔 | |||
| server.cloneTaskManagerScanIntervalMs=1000 | |||
| # clone chunk分片大小 | |||
| server.cloneChunkSplitSize=65536 | |||
| # for nos, pls set to 65536 | |||
| server.cloneChunkSplitSize=1048576 | |||
Cyber-SiKu
force-pushed
the
feat/upgreade_image_bs
branch
4 times, most recently
from
5d5543f
to
a2dd31b
Compare
|
cicheck |
wu-hanqing
approved these changes
Aug 7, 2023
xu-chaojie
reviewed
Aug 7, 2023
| RUN mkdir -p /etc/curvefs /core /etc/curve && chmod a+x /entrypoint.sh \ | ||
| && cp /curvefs/tools/sbin/curvefs_tool /usr/bin \ | ||
| && cp /curvefs/tools-v2/sbin/curve /usr/bin/ | ||
| ENTRYPOINT ["/entrypoint.sh"] |
There was a problem hiding this comment.
this line is no need any more？
There was a problem hiding this comment.
this line is no need any more？
it will use parent image entrypoint.
xu-chaojie
reviewed
Aug 7, 2023
| @@ -117,10 +117,10 @@ void FileLockManager::LockInternal(const std::string& path, | |||
|
|
|||
| if (lockType == kRead) { | |||
| // get read lock | |||
| entry->rwLock_.RDLock(); | |||
| bthread_rwlock_rdlock(&entry->rwLock_); | |||
There was a problem hiding this comment.
why chanage this lock to bthread lock
There was a problem hiding this comment.
why chanage this lock to bthread lock
The original way will have some problems in the higher version of gcc
|
cherry-pick this to release1.2.7 ？ |
ok |
0. upgrade image frome debian9 to debian11 1. build in docker 2. ut run in docker Signed-off-by: Cyber-SiKu <Cyber-SiKu@outlook.com>
Signed-off-by: Cyber-SiKu <Cyber-SiKu@outlook.com>
Cyber-SiKu
force-pushed
the
feat/upgreade_image_bs
branch
from
a2dd31b
to
6375d5e
Compare
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
xu-chaojie
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List