[refactor] CurveBS: unify bs and fs apply queue #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
wu-hanqing
reviewed
Jul 25, 2023
Signed-off-by: Xinlong Chen <xl_chen@zju.edu.cn>
Xinlong-Chen
force-pushed
the
bs-refactor-apply-queue
branch
from
d71601f
to
d1c32af
Compare
|
cicheck |
|
@wu-hanqing @ilixiaocui PTAL~ |
wu-hanqing
approved these changes
Jul 27, 2023
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
SeanHai
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #1598
Problem Summary:
What is changed and how it works?
What's Changed:
unify bs and fs apply queue.
How it Works:
simply moving
Schedulein apply queue toChunkOpRequestas a utils.Side effects(Breaking backward compatibility? Performance regression?):
Check List