[tools-v2] add bs check server based on pr2463 #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pengpengSir <2968332764@qq.com> fix bs check server Signed-off-by: pengpengSir <2968332764@qq.com> seperate command Signed-off-by: pengpengSir <2968332764@qq.com> Update server.go Signed-off-by: pengpengSir <82749014+pengpengSir@users.noreply.github.com>
|
cicheck |
1 similar comment
|
cicheck |
|
@montaguelhz PTAL |
Cyber-SiKu
reviewed
Jul 26, 2023
| ) | ||
|
|
||
| const ( | ||
| serverExample = `$ curve bs check server` |
| cobrautil.ROW_SERVER, | ||
| }) | ||
| sCmd.TableNew.AppendBulk(list) | ||
| sCmd.Result = sCmd.rows |
caoxianfei1
force-pushed
the
pengpengsir-pr2463
branch
from
0e19175
to
d501009
Compare
Signed-off-by: caoxianfei1 <caoxianfei@corp.netease.com>
caoxianfei1
force-pushed
the
pengpengsir-pr2463
branch
from
d501009
to
e919cb7
Compare
Cyber-SiKu
approved these changes
Jul 26, 2023
|
LGTM |
montaguelhz
approved these changes
Jul 26, 2023
|
cicheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This pr is implemented based on #2463, add bs check server command
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List