build: add braft format patch #2661

wu-hanqing · 2023-07-28T09:40:27Z

What problem does this PR solve?

Issue Number: #xxx

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

Relevant documentation/comments is changed or added
I acknowledge that all my contributions will be made under the project's license

wu-hanqing · 2023-07-28T09:53:22Z

cicheck

wu-hanqing · 2023-07-28T14:06:17Z

cicheck

wu-hanqing · 2023-07-29T03:12:22Z

cicheck

wu-hanqing · 2023-08-01T03:14:14Z

cicheck

wu-hanqing · 2023-08-01T08:27:06Z

cicheck

wu-hanqing · 2023-08-02T12:10:28Z

cicheck

Cyber-SiKu · 2023-08-22T02:00:02Z

@wu-hanqing continue？

wu-hanqing · 2023-08-29T09:40:29Z

cicheck

wu-hanqing · 2023-08-29T09:50:08Z

cicheck

YunhuiChen · 2023-08-29T10:50:25Z

cicheck

SeanHai · 2023-08-31T02:55:31Z

src/client/utils.h

+// Adjust the soft limit of open files to hard limit.
+// If |limit| equals 0, then directly return true.
+// If hard limit is less than |limit| than return false.
+bool AdjustOpenFileSoftLimit(uint64_t limit);


Can this limit be adjusted dynamically?

we can use prlimit to change running process's soft and hard limits

AdjustOpenFileSoftLimitToHardLimit is better?
Otherwise it looks like setting softlimit to limit

SeanHai · 2023-08-31T02:59:12Z

conf/client.conf

@@ -152,6 +152,14 @@ global.metricDummyServerStartPort=9000
 # 是否关闭健康检查: true/关闭 false/不关闭
 global.turnOffHealthCheck=true

+# minimal open file limit


minimal limit? has maximum limit?

This minimal limit affects how many TCP sockets the client can create, if it's too low, client can't create TCP sockets which will result in an IO Error.

A safe value for this is twice the number of cluster disks

SeanHai · 2023-08-31T02:59:23Z

conf/client.conf

+#       the number of sockets is related to the number of chunkserver and mds in the cluster,
+#       and during some exception handling processes, client will create additional sockets
+#       the SAFE value is 2 * (#chunkserver + #mds)
+global.minOpenFileLimit=65536


each client 65536?

Lowering it to 1024 and it's fine in most cases.

wu-hanqing · 2023-09-01T03:15:13Z

cicheck

wu-hanqing · 2023-09-01T05:52:32Z

cicheck

wu-hanqing · 2023-09-01T07:18:27Z

cicheck

wu-hanqing · 2023-09-01T09:09:22Z

cicheck

wu-hanqing · 2023-09-04T08:00:17Z

cicheck

wu-hanqing · 2023-09-05T01:52:58Z

cicheck

wu-hanqing · 2023-09-05T02:40:56Z

cicheck

Cyber-SiKu · 2023-09-21T11:38:09Z

src/client/config_info.h

@@ -274,6 +274,7 @@ struct IOOption {
 struct CommonConfigOpt {
    bool mdsRegisterToMDS = false;
    bool turnOffHealthCheck = false;
+    uint32_t minimalOpenFiles = 65536;


Put the description of the configuration item in a comment.

Cyber-SiKu · 2023-09-21T12:02:00Z

src/client/utils.h

+namespace client {
+
+// Adjust the soft limit of open files to hard limit.
+// If |limit| equals 0, then directly return true.


limit is uint64_t

It seems to me that this code means to set softlimit to hardlimit. But hardlimit has a lower limit called `limit``.

that's right.

Cyber-SiKu

that is all

Cyber-SiKu

Do you think my understanding is correct?

wu-hanqing · 2023-09-21T14:50:30Z

cicheck

Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>

wu-hanqing · 2023-09-21T15:18:28Z

cicheck

wu-hanqing · 2023-09-21T15:53:38Z

cicheck

wu-hanqing · 2023-09-22T01:41:10Z

cicheck

wu-hanqing · 2023-09-22T01:43:04Z

cicheck

wu-hanqing · 2023-09-22T02:08:14Z

cicheck

wu-hanqing · 2023-09-22T02:43:59Z

cicheck

wu-hanqing · 2023-09-22T03:40:01Z

cicheck

wu-hanqing · 2023-09-22T07:07:39Z

cicheck

wu-hanqing · 2023-09-22T14:35:28Z

cicheck

wu-hanqing force-pushed the build/braft-patch branch 2 times, most recently from 1e545a6 to 22370e8 Compare July 28, 2023 09:52

wu-hanqing force-pushed the build/braft-patch branch from 22370e8 to a614e1a Compare July 28, 2023 13:55

wu-hanqing force-pushed the build/braft-patch branch from a614e1a to 33cab42 Compare July 29, 2023 03:11

wu-hanqing force-pushed the build/braft-patch branch from 32796a9 to 88e51fb Compare August 2, 2023 12:10

wu-hanqing requested review from SeanHai and Cyber-SiKu August 22, 2023 09:20

wu-hanqing force-pushed the build/braft-patch branch from 25de4f1 to 7b4adf1 Compare August 29, 2023 09:38

SeanHai reviewed Aug 31, 2023

View reviewed changes

wu-hanqing force-pushed the build/braft-patch branch from 7b4adf1 to 015be99 Compare September 1, 2023 03:13

wu-hanqing force-pushed the build/braft-patch branch from 015be99 to 57ff2f3 Compare September 1, 2023 06:01

wu-hanqing force-pushed the build/braft-patch branch from 57ff2f3 to f19891c Compare September 1, 2023 09:07

Cyber-SiKu reviewed Sep 21, 2023

View reviewed changes

wu-hanqing force-pushed the build/braft-patch branch from f19891c to 220b79b Compare September 21, 2023 15:11

wu-hanqing added 11 commits September 21, 2023 23:14

client: fix unexpected get leader request

3f36080

Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>

build: add braft format patch

e55541f

Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>

build: update hedron compile commands

2898fc4

Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>

build: add version suffix for debian package

8487bc3

Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>

fix(chunkserver): invalid memroy access

68e5e64

Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>

nebd: set nofile soft limit to hard limit

e93b09a

Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>

client: set nofile limit

516a7c7

Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>

curvebs(mds): delete unnecessary error logs

0f8b51d

Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>

bvar: warning on conflict bvar name

6e5b4e0

Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>

curvebs(mds): reset SIGPIPE handler

064e841

Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>

Update submodule nbd to 15dd1ee

d6a0330

Signed-off-by: Hanqing Wu <wuhanqing@corp.netease.com>

wu-hanqing force-pushed the build/braft-patch branch from 220b79b to d6a0330 Compare September 21, 2023 15:17

Cyber-SiKu approved these changes Sep 22, 2023

View reviewed changes

SeanHai approved these changes Sep 25, 2023

View reviewed changes

wu-hanqing merged commit 4ab72af into opencurve:master Sep 25, 2023
4 checks passed

build: add braft format patch #2661

build: add braft format patch #2661

Conversation

wu-hanqing commented Jul 28, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

wu-hanqing commented Jul 28, 2023

wu-hanqing commented Jul 28, 2023

wu-hanqing commented Jul 29, 2023

wu-hanqing commented Aug 1, 2023

wu-hanqing commented Aug 1, 2023

wu-hanqing commented Aug 2, 2023

Cyber-SiKu commented Aug 22, 2023

wu-hanqing commented Aug 29, 2023

wu-hanqing commented Aug 29, 2023

YunhuiChen commented Aug 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cyber-SiKu Sep 21, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wu-hanqing commented Sep 1, 2023

wu-hanqing commented Sep 1, 2023

wu-hanqing commented Sep 1, 2023

wu-hanqing commented Sep 1, 2023

wu-hanqing commented Sep 4, 2023

wu-hanqing commented Sep 5, 2023

wu-hanqing commented Sep 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cyber-SiKu left a comment

Choose a reason for hiding this comment

Cyber-SiKu left a comment

Choose a reason for hiding this comment

wu-hanqing commented Sep 21, 2023

wu-hanqing commented Sep 21, 2023

wu-hanqing commented Sep 21, 2023

wu-hanqing commented Sep 22, 2023

wu-hanqing commented Sep 22, 2023

wu-hanqing commented Sep 22, 2023

wu-hanqing commented Sep 22, 2023

wu-hanqing commented Sep 22, 2023

wu-hanqing commented Sep 22, 2023

wu-hanqing commented Sep 22, 2023

Cyber-SiKu Sep 21, 2023 •

edited