[feat] support upgdade curve #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a typo, upgrade instead of upgeade. |
montaguelhz
reviewed
Aug 5, 2023
| upgradeCmd := &UpgradeCommand{ | ||
| FinalCurveCmd: basecmd.FinalCurveCmd{ | ||
| Use: "upgrade", | ||
| Short: "upgreade the curve to newst version", |
There was a problem hiding this comment.
upgrade the curve to latest version
There was a problem hiding this comment.
upgrade the curve to latest version
fix
| defer resp.Body.Close() | ||
| body, err := io.ReadAll(resp.Body) | ||
| if err != nil { | ||
| return fmt.Errorf("get curve newst version error: %v", err) |
Cyber-SiKu
force-pushed
the
feat/upgrade_tools_v2
branch
from
ee50043
to
744cf58
Compare
|
cicheck |
Signed-off-by: Cyber-SiKu <Cyber-SiKu@outlook.com>
Cyber-SiKu
force-pushed
the
feat/upgrade_tools_v2
branch
from
744cf58
to
975051c
Compare
montaguelhz
approved these changes
Aug 7, 2023
|
Very glad to witness a milestone of the curve-cli. |
|
cicheck |
Xinlong-Chen
reviewed
Aug 8, 2023
| return err | ||
| } | ||
|
|
||
| if info.Mode().Perm()&(1<<(uint(7))) == 0 { |
There was a problem hiding this comment.
code format, add some space~
|
cicheck |
3 similar comments
|
cicheck |
|
cicheck |
|
cicheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List