improve partition range management #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
Wine93
approved these changes
Oct 16, 2023
wu-hanqing
reviewed
Oct 16, 2023
| @@ -55,6 +55,8 @@ struct ClusterInformation { | |||
| std::string clusterId; | |||
| // <fsId, partition index of this fs> | |||
| std::map<uint32_t, uint32_t> partitionIndexs; | |||
| // <fsId, next inode id> | |||
| std::unordered_map<uint32_t, uint64_t> fsMaxAllocatedInodeId; | |||
There was a problem hiding this comment.
How about fsNextInodeId? And there are also some related functions that can be modified according to this.
Signed-off-by: wanghai01 <seanhaizi@163.com>
SeanHai
force-pushed
the
fix_partition_range_error
branch
from
e239589
to
47debfa
Compare
|
cicheck |
add utests |
wu-hanqing
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The previous logic of allocate inode range to partition is: index of partiton in this fs * range form conf.
For example, there are five partitions in fs and each manage 100 inodes:
p1 0-99
p2 100-199
p3 200-299
p4 300-399
p5 400-499
If you make this conf value smaller(maybe 80) and upgrade mds:
p1 0-99
p2 100-199
p3 200-299
p4 300-399
p5 400-499
p6: 400-479 new allocated partition will have repetitive parts with previous partition.
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
Now we will change allocation algorithm and record max inodeId of fs.
previous:
after fix:
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List