Feat/curvefs/client/change disk cache conf on fly #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
SeanHai
reviewed
Sep 1, 2023
curvefs/conf/client.conf
Outdated
| @@ -245,9 +245,10 @@ diskCache.trimCheckIntervalSec=5 | |||
| # the interval of check to trim load file to s3 | |||
| diskCache.asyncLoadPeriodMs=5 | |||
| # start trim file when disk cache use ratio is Greater than fullRatio, | |||
| # util less than safeRatio | |||
| # util less than safeRatio * trimeRatio / 100 | |||
There was a problem hiding this comment.
trimeRatio -> trimRatio
Is the time point of start trim reaching fullRatio or trimRatio? Fix code comments if reach trimRatio
There was a problem hiding this comment.
trimeRatio -> trimRatio Is the time point of start trim reaching fullRatio or trimRatio? Fix code comments if reach trimRatio
fullRatio start to trim
wu-hanqing
reviewed
Sep 1, 2023
| << ", usedBytes is: " << usedBytes | ||
| << ", use ratio is: " << ratio; | ||
| << ", usedBytes is: " << usedBytes << ", use ratio is: " << ratio | ||
| << ", baseRatio is: " << baseRatio; | ||
| return false; | ||
| } | ||
|
|
||
| // TODO(wuhongsong): | ||
| // See Also: https://github.com/opencurve/curve/issues/1534 | ||
| bool DiskCacheManager::IsExceedFileNums() { | ||
| uint64_t fileNums = cachedObjName_->Size(); |
There was a problem hiding this comment.
Implementation of Size() may have problem, access size_ should protected by lock.
| @@ -53,6 +56,19 @@ DEFINE_validator(avgReadFileBytes, &pass_uint64); | |||
| DEFINE_uint64(avgReadFileIops, 0, "the read throttle iops of disk cache"); | |||
| DEFINE_validator(avgReadFileIops, &pass_uint64); | |||
|
|
|||
| DEFINE_uint32(diskNearFullRatio, 70, "the nearfull ratio of disk cache"); | |||
There was a problem hiding this comment.
typo: nearful
fix
Cyber-SiKu
force-pushed
the
feat/curvefs/client/change_diskCacheConf_onFly
branch
from
177837e
to
14731c9
Compare
SeanHai
approved these changes
Sep 4, 2023
2 tasks
Cyber-SiKu
force-pushed
the
feat/curvefs/client/change_diskCacheConf_onFly
branch
2 times, most recently
from
62b1d54
to
d5a9de4
Compare
Signed-off-by: Cyber-SiKu <Cyber-SiKu@outlook.com>
Cyber-SiKu
force-pushed
the
feat/curvefs/client/change_diskCacheConf_onFly
branch
from
d5a9de4
to
d5af8dc
Compare
|
cicheck |
1 similar comment
|
cicheck |
wuhongsong
approved these changes
Sep 4, 2023
Cyber-SiKu
deleted the
feat/curvefs/client/change_diskCacheConf_onFly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List