Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]tools-v2: add snapshot utils #2758

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

baytan0720
Copy link
Member

What problem does this PR solve?

too much snapshot const and functions are private

Issue Number: #xxx

Problem Summary:

public snapshot const and functions in internal/utils/snapshot.go

What is changed and how it works?

What's Changed:

create tools-v2/internal/utils/snapshot.go
move and modify tools-v2/pkg/cli/command/curvebs/delete/volume/clone.go to tools-v2/pkg/cli/command/curvebs/delete/volume/clone/clone.go
move and modify tools-v2/pkg/cli/command/curvebs/delete/volume/recover.go to tools-v2/pkg/cli/command/curvebs/delete/volume/recover/recover.go
delete tools-v2/pkg/cli/command/curvebs/delete/volume/clone_or_recover.go

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@baytan0720
Copy link
Member Author

cicheck

Signed-off-by: baytan0720 <baytan2@hotmail.com>
@baytan0720
Copy link
Member Author

cicheck

1 similar comment
@baytan0720
Copy link
Member Author

cicheck

@Cyber-SiKu
Copy link
Contributor

cicheck

1 similar comment
@baytan0720
Copy link
Member Author

cicheck

@Cyber-SiKu Cyber-SiKu merged commit 862d8b0 into opencurve:master Sep 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants