[feat]curvefs/mds: change some config on fly #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyber-SiKu
force-pushed
the
feat/curvefs/change_conf_on_fly
branch
from
bb66c12
to
ab5cafe
Compare
Cyber-SiKu
changed the title
Cyber-SiKu
force-pushed
the
feat/curvefs/change_conf_on_fly
branch
from
ab5cafe
to
2fd200f
Compare
|
cicheck |
Cyber-SiKu
force-pushed
the
feat/curvefs/change_conf_on_fly
branch
5 times, most recently
from
2e762fe
to
113aa40
Compare
|
spell weird... TimeOut -> Timeout maybe |
h0hmj
approved these changes
Oct 19, 2023
wu-hanqing
reviewed
Oct 19, 2023
| // the maximun peroid that heartbeat is missed without | ||
| // setting the metaserver to offline status and alarm. | ||
| // scheduling will depend on this status of metaserver | ||
| DEFINE_uint64(heartbeat_OffLineTimeOutMs, 1800000, |
There was a problem hiding this comment.
its name is a hyper monster 👿, just heartbeat_offline_timeout_ms
| // background process will alarm during the inspection once it | ||
| // finds out that heartbeat is missed after heartbeatMissTimeOut peroid | ||
| DEFINE_uint64( | ||
| heartbeat_MissTimeOutMs, 30000, |
| @@ -129,7 +140,7 @@ bool TrashImpl::NeedDelete(const TrashItem &item) { | |||
| // if fs recycleTimeHour is not 0, return true | |||
| uint64_t recycleTimeHour = GetFsRecycleTimeHour(item.fsId); | |||
| if (recycleTimeHour == 0) { | |||
| return ((now - item.dtime) >= options_.expiredAfterSec); | |||
| return ((now - item.dtime) >= FLAGS_trash_expiredAfterSec); | |||
There was a problem hiding this comment.
if so, should options_.expiredAfterSec be removed?
There was a problem hiding this comment.
if so, should
options_.expiredAfterSecbe removed?
The reason for retaining this is to consider that the configuration-related content will be rewritten later. If you keep it, you can know that there is such a configuration item.
| while (sleeper_.wait_for(std::chrono::seconds(options_.scanPeriodSec))) { | ||
| ScanEveryTrash(); | ||
| } | ||
| while (sleeper_.wait_for(std::chrono::seconds(FLAGS_trash_scanPeriodSec))) { |
There was a problem hiding this comment.
ditto, remove options_.scanPeriodSec?
1. use gflag to change mds heartbeatMissTimeOutMs on fly 2. use gflag to change metaserver transh.expiredAfterSec on fly 3. use gflag to change metaserver transh.scanPeriodSec on fly 4. use gflag to change client fs.disableXattr on fly 5. set client s3.maxAsyncRequestInflightBytes default vale to 1GiB Signed-off-by: Cyber-SiKu <Cyber-SiKu@outlook.com>
Cyber-SiKu
force-pushed
the
feat/curvefs/change_conf_on_fly
branch
from
113aa40
to
5c77924
Compare
fix |
|
cicheck |
5 similar comments
|
cicheck |
|
cicheck |
|
cicheck |
|
cicheck |
|
cicheck |
wu-hanqing
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Use the following command to observe the status of the corresponding metaserver
watch -n 1 "curl -X POST http://xxx.xxx.xxx.xxx:xxxx/TopologyService/ListMetaServer -H 'Content-Type: application/protobuf' -d $'{\n \"serverID\": 1\n}' | jq"Use the following command to modify the corresponding configuration items:
Increase the log level of deleted inodes and observe the logs.
curl xxx.xxx.xxx.xxx:xxxx/flags/fs_disableXattr\?setvalue=truecurl xxx.xxx.xxx.xxx:xxxx/flags/fs_disableXattr\?setvalue=falseObserve whether the change time of onlineState changes according to the modification.
Side effects(Breaking backward compatibility? Performance regression?):
Check List