[feat]curvefs/metaserver: add delete inode monitor #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyber-SiKu
force-pushed
the
feat/curvefs/metaserver_delete_monitor
branch
from
6b1964a
to
1e63a9c
Compare
|
cicheck |
1 similar comment
|
cicheck |
wu-hanqing
reviewed
Oct 19, 2023
| @@ -151,6 +166,7 @@ class S3ClientAdaptorImpl : public S3ClientAdaptor { | |||
| uint64_t batchSize_; | |||
| uint32_t objectPrefix_; | |||
| bool enableBatchDelete_; | |||
| std::unique_ptr<S3ClientAdaptorMetric> metric_; | |||
There was a problem hiding this comment.
no need to save metric as a pointer, just S3ClientAdaptorMetric metric_?
There was a problem hiding this comment.
no need to save metric as a pointer, just
S3ClientAdaptorMetric metric_?
fix
Cyber-SiKu
force-pushed
the
feat/curvefs/metaserver_delete_monitor
branch
from
1e63a9c
to
c61ac70
Compare
|
cicheck |
3 similar comments
|
cicheck |
|
cicheck |
|
cicheck |
SeanHai
approved these changes
Oct 20, 2023
Cyber-SiKu
force-pushed
the
feat/curvefs/metaserver_delete_monitor
branch
from
c61ac70
to
472930d
Compare
|
cicheck |
wu-hanqing
approved these changes
Oct 23, 2023
Signed-off-by: Cyber-SiKu <Cyber-SiKu@outlook.com>
Cyber-SiKu
force-pushed
the
feat/curvefs/metaserver_delete_monitor
branch
from
472930d
to
21d2d4c
Compare
|
cicheck |
4 similar comments
|
cicheck |
|
cicheck |
|
cicheck |
|
cicheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List