Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix side effect of Remove operation. #2852

Closed
wants to merge 1 commit into from
Closed

Fix side effect of Remove operation. #2852

wants to merge 1 commit into from

Commits on Nov 9, 2023

  1. Fix side effect of Remove operation. 

    In the original ARC paper, there was no explanation of how Remove should be
handled when the cache is full. The Remove operation would have a side effect
on subsequent Put operations when the cache is not full, which is still
evicting items even though it's clear that there is no need to evict when
the cache is not full.

Now, code has been added to check if the cache is full to avoid performance
degradation.

Also fix c_, it should be max_count.
Also add unittest.

Signed-off-by: Xu Yifeng <bsddiy2@163.com>
    @skypexu
    skypexu committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    d3f5263 View commit details
    Browse the repository at this point in the history