nbd: fix concurrent nbd map #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanHai
approved these changes
Mar 26, 2021
xu-chaojie
reviewed
Mar 26, 2021
nbd/src/util.cpp
Outdated
| } | ||
| } | ||
|
|
||
| int map_on_nbd_device_by_devpath(int sockfd, const std::string& devpath, |
There was a problem hiding this comment.
This function can be reused by the above function through some adjustments
nbd/src/util.cpp
Outdated
| @@ -441,6 +393,74 @@ int load_module(NBDConfig *cfg) { | |||
| return ret; | |||
| } | |||
|
|
|||
| int map_on_unused_nbd_device(int sockfd, std::string* devpath, int* nbdindex) { | |||
There was a problem hiding this comment.
This function can be protect function in the parent class ’NBDController' ?
wu-hanqing
force-pushed
the
fix-nbd-concurrent-map
branch
from
0c5f459
to
2e9f178
Compare
xu-chaojie
approved these changes
Mar 29, 2021
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
thanos: Selected Students for Community Bridge Q3-Q4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List