Added new Docker environment with Android build tools v30 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched to Android command line tools instead of deprecated sdk-tools. - Java JRE 17 - Gradle 7.5.1 - CMake 3.22.1 The environment requires namespace definition in build.gradle.
This was referenced Nov 14, 2023
mshabunin
reviewed
Nov 16, 2023
| && mkdir -p $ANDROID_HOME/cmdline-tools/latest \ | ||
| && mv cmdline-tools/* $ANDROID_HOME/cmdline-tools/latest/ \ | ||
| && tree $ANDROID_HOME \ | ||
| && echo "y\n" > /tmp/yes \ |
There was a problem hiding this comment.
I wrote this script for installing SDK some time ago: https://github.com/mshabunin/opencv-android-build/blob/master/scripts/get_sdk.sh
- might be necessary to run
sdkmanager --updatefirst - you can run
yes | sdkmanager --licensesonce and skip license request further - why run several commands when
sdkmanager --install <pkg> <pkg> <pkg> ...form can be used
mshabunin
reviewed
Nov 16, 2023
| # Image name: quay.io/opencv-ci/opencv-androidsdk-30 | ||
| # For 4.x branch | ||
|
|
||
| FROM ubuntu:20.04 |
There was a problem hiding this comment.
I just used the same base image as before. It does not actually matters here, because most of work is done by cross tools.
mshabunin
reviewed
Nov 16, 2023
| software-properties-common \ | ||
| build-essential ccache ninja-build \ | ||
| python3 python3-pip curl zip unzip file \ | ||
| openjdk-8-jdk openjdk-17-jre libncurses5 tree \ |
There was a problem hiding this comment.
Why 2 JDKs are necessary?
There was a problem hiding this comment.
JDK 8 is used for Android code. JRE 17 is used for SDK tools, Gradle, etc.
mshabunin
reviewed
Nov 16, 2023
| apt-get install -y --no-install-recommends git && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| RUN mkdir -p /opt/gradle && \ |
There was a problem hiding this comment.
Is it possible to install system gradle package? I thought that required version will be automatically downloaded by project if necessary.
For example we can see in the logs that gradle 5.6.4 has been used despite having 7.5.1 installed.
There was a problem hiding this comment.
I try align gradle version here and in main repo: opencv/opencv#24473. The goal is to re-use everything from docker and do not download tools on the go.
mshabunin
approved these changes
Nov 16, 2023
asmorkalov
pushed a commit
to opencv/opencv
that referenced
this pull request
Nov 17, 2023
Updated Android samples for modern Android studio. Added OpenCV from Maven support. #24473 Updated samples for recent Android studio: - added namespace field that is required in build.gradle files - replaced _switch_ by _if-else_ because it doesn't work with constants from resources - added missed log library dependency in face-detection/jni/CMakeLists.txt - use local.properties to define NDK location Added support for OpenCV from Maven. Now you can choose 3 possible sources of OpenCV lib in settings.gradle: SDK path, local Maven repository, public Maven repository. (Creating Maven repository from SDK is added here #24456 ) There are differences in project configs for SDK and Maven versions: - different dependencies in build.gradle - different OpenCV library names in CMakeLists.txt - SDK version requires OpenCV_DIR definition Requires: - opencv/ci-gha-workflow#124 - opencv-infrastructure/opencv-gha-dockerfile#26
IskXCr
pushed a commit
to Haosonn/opencv
that referenced
this pull request
Dec 20, 2023
Updated Android samples for modern Android studio. Added OpenCV from Maven support. opencv#24473 Updated samples for recent Android studio: - added namespace field that is required in build.gradle files - replaced _switch_ by _if-else_ because it doesn't work with constants from resources - added missed log library dependency in face-detection/jni/CMakeLists.txt - use local.properties to define NDK location Added support for OpenCV from Maven. Now you can choose 3 possible sources of OpenCV lib in settings.gradle: SDK path, local Maven repository, public Maven repository. (Creating Maven repository from SDK is added here opencv#24456 ) There are differences in project configs for SDK and Maven versions: - different dependencies in build.gradle - different OpenCV library names in CMakeLists.txt - SDK version requires OpenCV_DIR definition Requires: - opencv/ci-gha-workflow#124 - opencv-infrastructure/opencv-gha-dockerfile#26
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
Updated Android samples for modern Android studio. Added OpenCV from Maven support. opencv#24473 Updated samples for recent Android studio: - added namespace field that is required in build.gradle files - replaced _switch_ by _if-else_ because it doesn't work with constants from resources - added missed log library dependency in face-detection/jni/CMakeLists.txt - use local.properties to define NDK location Added support for OpenCV from Maven. Now you can choose 3 possible sources of OpenCV lib in settings.gradle: SDK path, local Maven repository, public Maven repository. (Creating Maven repository from SDK is added here opencv#24456 ) There are differences in project configs for SDK and Maven versions: - different dependencies in build.gradle - different OpenCV library names in CMakeLists.txt - SDK version requires OpenCV_DIR definition Requires: - opencv/ci-gha-workflow#124 - opencv-infrastructure/opencv-gha-dockerfile#26
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
Updated Android samples for modern Android studio. Added OpenCV from Maven support. opencv#24473 Updated samples for recent Android studio: - added namespace field that is required in build.gradle files - replaced _switch_ by _if-else_ because it doesn't work with constants from resources - added missed log library dependency in face-detection/jni/CMakeLists.txt - use local.properties to define NDK location Added support for OpenCV from Maven. Now you can choose 3 possible sources of OpenCV lib in settings.gradle: SDK path, local Maven repository, public Maven repository. (Creating Maven repository from SDK is added here opencv#24456 ) There are differences in project configs for SDK and Maven versions: - different dependencies in build.gradle - different OpenCV library names in CMakeLists.txt - SDK version requires OpenCV_DIR definition Requires: - opencv/ci-gha-workflow#124 - opencv-infrastructure/opencv-gha-dockerfile#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to Android command line tools instead of deprecated sdk-tools.
The environment requires namespace definition in build.gradle.