Fix build issues on Windows with Clang #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- By default we passed MSVC flags on Windows unconditionally, extended this behavior to the Clang case; - Did some tricks to make things work in this configuration; - Raised the minimum required CMake version based on recent warnings.
|
Unfortunately ADE's GH Actions don't have Windows.. Opened #37, but meanwhile tested this branch locally with MSVS 2019. Sort-of works |
ilya-lavrenov
approved these changes
Sep 6, 2023
|
@TolyaTalamanov @alexgiving can you please have a look on this too? A write access reviewer approval is required (technically) |
dmatveev
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building w/LLVM:
Have LLVM, CMake, and Ninja in your PATH. Then:
Should fix #24