Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVAT UI: batch of fixes #1705

Merged
merged 25 commits into from
Jun 25, 2020
Merged

CVAT UI: batch of fixes #1705

merged 25 commits into from
Jun 25, 2020

Conversation

ActiveChooN
Copy link
Contributor

@ActiveChooN ActiveChooN commented Jun 14, 2020

Motivation and context

изображение

This PR resolve several issues and fix some of eslint problems.

Resolve #918
Resolve #1458
Resolve #1514
Resolve #1643
Resolve #1646
Resolve #1666

How has this been tested?

Manually

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@ActiveChooN ActiveChooN added the enhancement New feature or request label Jun 14, 2020
@coveralls
Copy link

coveralls commented Jun 14, 2020

Pull Request Test Coverage Report for Build 6136

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 65.136%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 1 77.35%
Totals Coverage Status
Change from base Build 6122: 0.004%
Covered Lines: 11006
Relevant Lines: 16486

💛 - Coveralls

@ActiveChooN ActiveChooN changed the title CVAT UI: batch of fixes [WIP] CVAT UI: batch of fixes Jun 17, 2020
@bsekachev
Copy link
Member

  1. When I press F2 (whenever I am), CVAT goes to dashboard. Settings modal is expected to be opened.
  2. It seems that these settings doesn't work: grid size, show all interpolation tracks, always show object details, auto save (I am not sure here, need to check)
  3. It would be great to remove extra white space on settings modal:
    Screenshot from 2020-06-17 17-53-42

CHANGELOG.md Outdated Show resolved Hide resolved
@ActiveChooN ActiveChooN changed the title [WIP] CVAT UI: batch of fixes CVAT UI: batch of fixes Jun 22, 2020
@bsekachev
Copy link
Member

The issue persists
Probably need to check event target

Peek 2020-06-23 08-27

cvat-canvas/src/typescript/canvasView.ts Outdated Show resolved Hide resolved
cvat-canvas/src/typescript/canvasView.ts Outdated Show resolved Hide resolved
Comment on lines +171 to +174
if (prevProps.showAllInterpolationTracks !== showAllInterpolationTracks) {
onFetchAnnotation();
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we dispatch this action immediately after changing settings?
Here: src/containers/header/settings-modal/workspace-settings.tsx Line 72

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsekachev, what about example future case when we change value by loading it from server? I think it can be more common way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ActiveChooN

I am not sure I understand you. What value? How are we going to get it from the server?
My idea is that now it is not obvious how the action is called after changing showAllInterpolationTracks.

@@ -42,7 +42,7 @@ export default function WorkspaceSettingsComponent(props: Props): JSX.Element {
onSwitchAutomaticBordering,
} = props;

const minAutoSaveInterval = 5;
const minAutoSaveInterval = 1;
Copy link
Member

@bsekachev bsekachev Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to change or for test only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsekachev, what is preventing us to decrease this parameter? I guess we discussed it sometime.

cvat-ui/src/containers/header/header.tsx Outdated Show resolved Hide resolved
bsekachev
bsekachev previously approved these changes Jun 24, 2020
Copy link
Contributor

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

See the complete overview on Codacy

}

.cvat-settings-modal .ant-modal-body{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


.cvat-settings-modal .ant-modal-body{
padding-top: 0;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsekachev bsekachev merged commit 49a7ad5 into develop Jun 25, 2020
@bsekachev bsekachev deleted the dk/batch-of-fixes branch June 25, 2020 14:54
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants