-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced errors notifications #7371
Conversation
@@ -56,7 +57,7 @@ def save(self, request): | |||
if "password1" in self.cleaned_data: | |||
try: | |||
adapter.clean_password(self.cleaned_data['password1'], user=user) | |||
except ValidationError as exc: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong exception class used, it caused 500 server error because of unhandled exception
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7371 +/- ##
===========================================
- Coverage 83.26% 83.20% -0.06%
===========================================
Files 373 373
Lines 39615 39714 +99
Branches 3701 3720 +19
===========================================
+ Hits 32984 33043 +59
- Misses 6631 6671 +40
|
@bsekachev |
Motivation and context
Resolved #7365
Examples:
instead of
instead of
instead of
instead of
instead of
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.