Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G-API: division test is disabled for MathOperatorTest #13147

Open
ghost opened this issue Nov 13, 2018 · 4 comments
Open

G-API: division test is disabled for MathOperatorTest #13147

ghost opened this issue Nov 13, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 13, 2018

Testing of the divsion operation has been disabled by @alalek with PR #13096

I am filing this issue in order to track fixing and re-enabling of these tests

Reasoning provided by @alalek about these tests:

Div by exact zero has been changed in OpenCV 4.x (to follow IEEE 754 for floating point numbers): #12826

Div by values near zero provides unreliable results.
Small error in denominator provides has huge impact on result. So inputs should be "normalized" (avoided values near zero), or compare function should be based on input values too (it is not enough to provide "expected" and "actual" results only)

@ghost ghost mentioned this issue Nov 13, 2018
@dmatveev
Copy link
Contributor

@elatkin is this issue still relevant? There was a PR merged

@ghost
Copy link
Author

ghost commented Nov 26, 2018

@elatkin is this issue still relevant? There was a PR merged

PR #13096 disables the opDiv and opDivR cases of the MathOperatorTestCPU

This issue intends to track fixing and restoring of those test cases

@dmatveev
Copy link
Contributor

Ok, thanks!

@alalek
Copy link
Member

alalek commented Nov 11, 2021

Looks like tests were updated by #18257 (4.5.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants