-
-
Notifications
You must be signed in to change notification settings - Fork 55.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
divide() with zero values #12826
Merged
Merged
divide() with zero values #12826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- always pass DEPTH_dst value to core/arithm kernel
/cc @dmatveev I disabled div by zero tests in G-API. |
@alalek, GAPI test failing on ppc64le, could you please take a look at https://ocv-power.imavr.com/#/builders/2/builds/1308? List failed tests (first 10):MathOpTestFluid/MathOpTest.MatricesAccuracyTest/DIV_1_16_1_1920x1080_0_0_1 [3, true, 16, 1, 1920x1080, -1, false, true, { gapi.kernel_package }] :
/worker/buildbot/Power8_Linux_gcc-5__opencv/opencv/modules/gapi/test/common/gapi_core_tests_inl.hpp:133: Failure
Expected: (countNonZeroPixels(cv::abs(out_mat_gapi - out_mat_ocv) > 0)) <= (0.01*out_mat_ocv.total()), actual: 40348 vs 20736
MathOpTestFluid/MathOpTest.MatricesAccuracyTest/DIV_1_16_1_1920x1080_0_1_1 [3, true, 16, 1, 1920x1080, -1, true, true, { gapi.kernel_package }] :
/worker/buildbot/Power8_Linux_gcc-5__opencv/opencv/modules/gapi/test/common/gapi_core_tests_inl.hpp:133: Failure
Expected: (countNonZeroPixels(cv::abs(out_mat_gapi - out_mat_ocv) > 0)) <= (0.01*out_mat_ocv.total()), actual: 40348 vs 20736
MathOpTestFluid/MathOpTest.MatricesAccuracyTest/DIV_1_16_1_1920x1080_1_0_1 [3, true, 16, 1, 1920x1080, 0, false, true, { gapi.kernel_package }] :
/worker/buildbot/Power8_Linux_gcc-5__opencv/opencv/modules/gapi/test/common/gapi_core_tests_inl.hpp:133: Failure
Expected: (countNonZeroPixels(cv::abs(out_mat_gapi - out_mat_ocv) > 0)) <= (0.01*out_mat_ocv.total()), actual: 40348 vs 20736
MathOpTestFluid/MathOpTest.MatricesAccuracyTest/DIV_1_16_1_1920x1080_1_1_1 [3, true, 16, 1, 1920x1080, 0, true, true, { gapi.kernel_package }] :
/worker/buildbot/Power8_Linux_gcc-5__opencv/opencv/modules/gapi/test/common/gapi_core_tests_inl.hpp:133: Failure
Expected: (countNonZeroPixels(cv::abs(out_mat_gapi - out_mat_ocv) > 0)) <= (0.01*out_mat_ocv.total()), actual: 40348 vs 20736
MathOpTestFluid/MathOpTest.MatricesAccuracyTest/DIV_1_16_1_1280x720_0_0_1 [3, true, 16, 1, 1280x720, -1, false, true, { gapi.kernel_package }] :
/worker/buildbot/Power8_Linux_gcc-5__opencv/opencv/modules/gapi/test/common/gapi_core_tests_inl.hpp:133: Failure
Expected: (countNonZeroPixels(cv::abs(out_mat_gapi - out_mat_ocv) > 0)) <= (0.01*out_mat_ocv.total()), actual: 17950 vs 9216
MathOpTestFluid/MathOpTest.MatricesAccuracyTest/DIV_1_16_1_1280x720_0_1_1 [3, true, 16, 1, 1280x720, -1, true, true, { gapi.kernel_package }] :
/worker/buildbot/Power8_Linux_gcc-5__opencv/opencv/modules/gapi/test/common/gapi_core_tests_inl.hpp:133: Failure
Expected: (countNonZeroPixels(cv::abs(out_mat_gapi - out_mat_ocv) > 0)) <= (0.01*out_mat_ocv.total()), actual: 17950 vs 9216
MathOpTestFluid/MathOpTest.MatricesAccuracyTest/DIV_1_16_1_1280x720_1_0_1 [3, true, 16, 1, 1280x720, 0, false, true, { gapi.kernel_package }] :
/worker/buildbot/Power8_Linux_gcc-5__opencv/opencv/modules/gapi/test/common/gapi_core_tests_inl.hpp:133: Failure
Expected: (countNonZeroPixels(cv::abs(out_mat_gapi - out_mat_ocv) > 0)) <= (0.01*out_mat_ocv.total()), actual: 17950 vs 9216
MathOpTestFluid/MathOpTest.MatricesAccuracyTest/DIV_1_16_1_1280x720_1_1_1 [3, true, 16, 1, 1280x720, 0, true, true, { gapi.kernel_package }] :
/worker/buildbot/Power8_Linux_gcc-5__opencv/opencv/modules/gapi/test/common/gapi_core_tests_inl.hpp:133: Failure
Expected: (countNonZeroPixels(cv::abs(out_mat_gapi - out_mat_ocv) > 0)) <= (0.01*out_mat_ocv.total()), actual: 17950 vs 9216
MathOpTestFluid/MathOpTest.MatricesAccuracyTest/DIV_1_16_1_640x480_0_0_1 [3, true, 16, 1, 640x480, -1, false, true, { gapi.kernel_package }] :
/worker/buildbot/Power8_Linux_gcc-5__opencv/opencv/modules/gapi/test/common/gapi_core_tests_inl.hpp:133: Failure
Expected: (countNonZeroPixels(cv::abs(out_mat_gapi - out_mat_ocv) > 0)) <= (0.01*out_mat_ocv.total()), actual: 5899 vs 3072
MathOpTestFluid/MathOpTest.MatricesAccuracyTest/DIV_1_16_1_640x480_0_1_1 [3, true, 16, 1, 640x480, -1, true, true, { gapi.kernel_package }] :
/worker/buildbot/Power8_Linux_gcc-5__opencv/opencv/modules/gapi/test/common/gapi_core_tests_inl.hpp:133: Failure
Expected: (countNonZeroPixels(cv::abs(out_mat_gapi - out_mat_ocv) > 0)) <= (0.01*out_mat_ocv.total()), actual: 5899 vs 3072 |
vpisarev
approved these changes
Oct 15, 2018
opencv-pushbot
pushed a commit
that referenced
this pull request
Oct 15, 2018
This was referenced Nov 10, 2018
ghost
mentioned this pull request
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: core
category: ocl
future
This issue can't be fixed during restrictions of the compatibility requirements
port/backport done
Label for maintainers. Authors of PR can ignore this
test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #12825
resolves #8413