Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v_signmask for RISC-V Vector #22558

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Fix v_signmask for RISC-V Vector #22558

merged 1 commit into from
Sep 25, 2022

Conversation

hanliutong
Copy link
Contributor

The original signmask implementation returned incorrect results in some cases (e.g. new test cases, 242 is returned but 2 is expected).

This is due to Vector Tail Agnostic in RVV, and this patch solves the problem by using "bitwise AND" to mask high bit.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Contributor

@hanliutong thanks for the fix. Could you squash commits before megre?

@hanliutong
Copy link
Contributor Author

@asmorkalov Commits are squashed now.

@asmorkalov asmorkalov merged commit a682f02 into opencv:4.x Sep 25, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
@asmorkalov asmorkalov added the bug label Jan 23, 2023
@asmorkalov asmorkalov added this to the 4.7.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants