Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage TensorFlow's NHWC data layout is smoother #10364

Merged
merged 1 commit into from Dec 22, 2017

Conversation

dkurt
Copy link
Member

@dkurt dkurt commented Dec 20, 2017

This pullrequest changes

Track TensorFlow layers' data layout.

resolves #9992
resolves #10065
resolves #10292

Merge with extra: opencv/opencv_extra#421

Please do not merge until we check all test cases from issues. Thanks!

@vpisarev
Copy link
Contributor

@dkurt, please, put the note here when it's ready to merge. OpenCV 3.4 is almost out, shall we put it there? I believe, since you provided extra tests and those tests pass along with the previous ones, at least this PR does not break anything. So, perhaps it should be merged.

@dkurt
Copy link
Member Author

dkurt commented Dec 21, 2017

@vpisarev, you're right. Let's merge it. At least one test case with simple classification network works correctly (#10292).

@vpisarev
Copy link
Contributor

👍

@opencv-pushbot opencv-pushbot merged commit 7e48fa5 into opencv:master Dec 22, 2017
@dkurt dkurt deleted the dnn_smooth_tf_data_layout branch January 20, 2018 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants