convertTo/assignTo does not need a channel value #12604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cv3d
force-pushed
the
cleanup/convertTo
branch
3 times, most recently
from
7c6fd0b
to
548acff
Compare
alalek
reviewed
Sep 21, 2018
| @param rtype desired output matrix type or, rather, the depth since the number of channels are the | ||
| same as the input has; if rtype is negative, the output matrix will have the same type as the input. | ||
| @param ddepth desired output matrix type or, rather, the depth since the number of channels are the | ||
| same as the input has; if ddepth is CV_DEPTH_AUTO, the output matrix will have the same type as the input. |
There was a problem hiding this comment.
Documentation already allows to using both type and depth in existed OpenCV versions.
So this change is questionable actually.
P.S. Allowing both is not a good decision for API if elements are same. I believe during smooth transition on type-safe enums there should be both overloads for ElemDepth and ElemType(second with additional check that CV_MAT_CN(src.type()) == CV_MAT_CN(rtype)).
There was a problem hiding this comment.
Should not we update the documentation to state that depth is enough?
cv3d
force-pushed
the
cleanup/convertTo
branch
from
548acff
to
1e5140e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
convertTo()andassignTo()with depth-only values