Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the ElemType register #12729

Closed
wants to merge 1 commit into from
Closed

Conversation

cv3d
Copy link
Contributor

@cv3d cv3d commented Oct 3, 2018

Merge with opencv/opencv_contrib#1807
replaces #12611
resolves #12584
related #12569

This pullrequest changes

  • Increase the supported depth types limit from 8 to 32
    • Introduced uint32, uint64, int64 and other special formats (i.e. raw, auto, undefined)
  • Increase the supported channels limit from 512 to 2048 (still extensible with further design work)
    • Use the next available (bigger) number of channels in case of invalid channel input
    • Great impact expected on various modules (e.g. DNN and feature2D)
  • Fully-backwards compatible with serialized files generated using older OpenCV versions
force_builders=Custom,Linux32,Win32,Win64 MSVS2017,ARMv7,ARMv8,Android pack
docker_image:Docs=docs-js
docker_image:Custom=ubuntu-cuda:16.04

@cv3d cv3d force-pushed the elemtype_redesign branch 3 times, most recently from b958f5c to b4b11f1 Compare October 6, 2018 17:35
@cv3d
Copy link
Contributor Author

cv3d commented Oct 13, 2018

Would you mind adding this PR to the 4.0.0-beta milestone?

@cv3d
Copy link
Contributor Author

cv3d commented Oct 19, 2018

@vpisarev I know you are busy, but I wonder what is the current state of this PR. Mind to let me know?

@vpisarev
Copy link
Contributor

@cv3d, it should stay closed until OpenCV 4.0

@cv3d
Copy link
Contributor Author

cv3d commented Oct 21, 2018

We try to do it all by OpenCV 4.0.

As you wish, although I understood previously you desire to do it by now.

@cv3d
Copy link
Contributor Author

cv3d commented Dec 1, 2018

Is there any update regarding this PR, and perhaps the other already closed PRs of mine?

@vpisarev A kind reminder.

@cv3d
Copy link
Contributor Author

cv3d commented Dec 11, 2018

@alalek, @mshabunin, @alexey-sidnev, @dkurt
It seems @vpisarev is not around in the last three weeks, and I wonder if anyone of you can update me on the current situation. E.g. Is there any estimated time on how long shall this PR waits?

I have been waiting patiently for two months, and I no longer feels motivated to contribute due to the way my PRs are being handled, despite my previous contributions for many years by now...
Is not OpenCV an open source project? Would Intel agree on what is happening here?

@dkurt
Copy link
Member

dkurt commented Dec 11, 2018

@cv3d, you're not alone. I've been waiting for merging my PR into TensorFlow for 4 months: tensorflow/tensorflow#21660. I don't know why Google don't want it 😄

Let's carefully review you changes. I don't think that a single programmer is able to make a decision to merge changes to the core of 20 y.o. library.

BTW, does GitHub allow to reopen your PRs? Why you do not just reopen it?

@cv3d
Copy link
Contributor Author

cv3d commented Dec 11, 2018

@dkurt Thank you for your support. I appreciate in advance all your efforts in review.
It seems as long as a PR is closed by a maintainer, the author cannot reopen it, and only maintainers can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign of the ElemType register for OpenCV v4
4 participants