Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix document about camera distortion parameters #12958

Merged
merged 1 commit into from Oct 27, 2018

Conversation

kamino410
Copy link
Contributor

@kamino410 kamino410 commented Oct 26, 2018

This pullrequest changes

The current documentation says that positive k1 causes barrel distortion and negative k1 causes pincushion distortion.
But it seems the opposite.

According to the formula, distorted point (x'', y'') moves toward the outside of the image when k1 > 0.
So it should cause not barrel distortion but pincushion distortion.

@catree
Copy link
Contributor

catree commented Oct 26, 2018

According to the formula, distorted point (x'', y'') moves toward the outside of the image when k1 > 0.

I agree with that.

So it should cause not barrel distortion but pincushion distortion.

Barrel and pincushion distortion (from Matlab documentation):

image

@kamino410
Copy link
Contributor Author

That's true.
But Edmund Optics defines them as follows.
fig-2-d

At least, I'm sure that cameras whose k1 is negative take figures having barrel distortion because

@paroj
Copy link
Contributor

paroj commented Oct 26, 2018

generated with k1=2, rest zero
cdist

@catree
Copy link
Contributor

catree commented Oct 26, 2018

@paroj Thanks for taking the time to check this.

@opencv-pushbot opencv-pushbot merged commit 3972c52 into opencv:3.4 Oct 27, 2018
@kamino410 kamino410 deleted the doc_dist_param branch October 28, 2018 02:50
@alalek alalek mentioned this pull request Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants