fix integer overflow for p.x when step is large #14327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalek
requested changes
Apr 15, 2019
| @@ -4903,7 +4903,7 @@ Point LineIterator::pos() const | |||
| { | |||
| Point p; | |||
| p.y = (int)((ptr - ptr0)/step); | |||
| p.x = (int)(((ptr - ptr0) - p.y*step)/elemSize); | |||
| p.x = (int)(((ptr - ptr0) - (long)p.y*step)/elemSize); | |||
There was a problem hiding this comment.
long is still 32-bit on Win32.
Consider using int64 here (or long long int).
|
@tomforge Do you have any progress on that? |
|
@asmorkalov No. I haven't been able to find time to do any extensive testing. Maybe we should close this first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #14326
This pullrequest changes
Add a cast to
longfor integer arithmetric that may potentially overflow in functionpos()ofcv::LineIterator