Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optim cg #1521

Merged
merged 5 commits into from Oct 29, 2013
Merged

Optim cg #1521

merged 5 commits into from Oct 29, 2013

Conversation

nailbiter
Copy link
Contributor

This contribution aims to implement the Nonlinear Conjugate Gradient optimization algorithm for optim module.

This work is supported by Google within the Google Summer of Code 2013 initiative. Mentor: Vadim Pisarevsky.

Implementation is based on
http://www.cs.cmu.edu/~quake-papers/painless-conjugate-gradient.pdf

So far we only have basic interface and empty test. But it compiles at
least.
Some interface was refined (most notably, the method for returning
Hessian was removed and the method for getting gradient was added as
optional to base Solver::Function class) and basic code for
setters/getters was added. Now is the time for the real work on an
algorithm.
Now everything is prepared for the pull request.
Fix failed builds that opencv's buildbot has got.
@ghost ghost assigned vpisarev Sep 29, 2013
@vpisarev
Copy link
Contributor

Alex, thank you! Looks good! Please, add copyright to the .cpp file.

@nailbiter
Copy link
Contributor Author

Vadim!

Done. Is that the correct copyright I've added? Also I would like to drive
your attention to the fact that non of my other .cpp or .hpp files has this
copyright. Should I add it to all the files?

Besides, if you have time, please look at the discussion I have with
Vincent's student about the particle filter I wrote
opencv/opencv_contrib#2 (comment)
In short, she proposes to change several parts of the code, but I'm not
sure whether that's the right thing to do.

Best Regards,
Alex

2013/9/30 Vadim Pisarevsky notifications@github.com

Alex, thank you! Looks good! Please, add copyright to the .cpp file.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1521#issuecomment-25326794
.

// License Agreement
// For Open Source Computer Vision Library
//
// Copyright (C) 2000-2008, Intel Corporation, all rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove Intel Corporation and Willow Garage from the copyright, put
"Copyright (C) 2013, OpenCV Foundation, all rights reserved."
instead

@vpisarev
Copy link
Contributor

Alexey, please, correct the copyright notice as pointed above. I will appreciate if you add the same thing to other files where the copyright is missing. I will take a look at the discussion of your pull request for opencv_contrib

@nailbiter
Copy link
Contributor Author

Done.

2013/9/30 Vadim Pisarevsky notifications@github.com

Alexey, please, correct the copyright notice as pointed above. I will
appreciate if you add the same thing to other files where the copyright is
missing. I will take a look at the discussion of your pull request for
opencv_contrib


Reply to this email directly or view it on GitHubhttps://github.com//pull/1521#issuecomment-25348637
.

Added the copyrights missing in all files that required so.
@vpisarev
Copy link
Contributor

looks good! There is some unrelated failure in stitching. Trying to rerun tests ...

@mdim
Copy link
Contributor

mdim commented Oct 18, 2013

@ vpisarev Vadim, any news?

@vpisarev
Copy link
Contributor

👍

opencv-pushbot pushed a commit that referenced this pull request Oct 29, 2013
@opencv-pushbot opencv-pushbot merged commit 0324932 into opencv:master Oct 29, 2013
@nailbiter
Copy link
Contributor Author

perfect, thanks

2013/10/29 OpenCV Pushbot notifications@github.com

Merged #1521 #1521.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1521
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants