New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optim cg #1521
Optim cg #1521
Conversation
Implementation is based on http://www.cs.cmu.edu/~quake-papers/painless-conjugate-gradient.pdf So far we only have basic interface and empty test. But it compiles at least.
Some interface was refined (most notably, the method for returning Hessian was removed and the method for getting gradient was added as optional to base Solver::Function class) and basic code for setters/getters was added. Now is the time for the real work on an algorithm.
Now everything is prepared for the pull request.
Fix failed builds that opencv's buildbot has got.
Alex, thank you! Looks good! Please, add copyright to the .cpp file. |
Vadim! Done. Is that the correct copyright I've added? Also I would like to drive Besides, if you have time, please look at the discussion I have with Best Regards, 2013/9/30 Vadim Pisarevsky notifications@github.com
|
// License Agreement | ||
// For Open Source Computer Vision Library | ||
// | ||
// Copyright (C) 2000-2008, Intel Corporation, all rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove Intel Corporation and Willow Garage from the copyright, put
"Copyright (C) 2013, OpenCV Foundation, all rights reserved."
instead
Alexey, please, correct the copyright notice as pointed above. I will appreciate if you add the same thing to other files where the copyright is missing. I will take a look at the discussion of your pull request for opencv_contrib |
Done. 2013/9/30 Vadim Pisarevsky notifications@github.com
|
Added the copyrights missing in all files that required so.
looks good! There is some unrelated failure in stitching. Trying to rerun tests ... |
@ vpisarev Vadim, any news? |
👍 |
perfect, thanks 2013/10/29 OpenCV Pushbot notifications@github.com
|
This contribution aims to implement the Nonlinear Conjugate Gradient optimization algorithm for optim module.
This work is supported by Google within the Google Summer of Code 2013 initiative. Mentor: Vadim Pisarevsky.