Support nGraph API #15537
Merged
Support nGraph API #15537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalek
reviewed
Sep 18, 2019
CMakeLists.txt
Outdated
| @@ -1595,19 +1595,22 @@ endif() | |||
|
|
|||
| if(WITH_INF_ENGINE OR INF_ENGINE_TARGET) | |||
| if(INF_ENGINE_TARGET) | |||
| list(GET INF_ENGINE_TARGET 0 ie_target) | |||
There was a problem hiding this comment.
Why is these changes here? They should be on the 3.4 branch already: #15376
Please rebase patch.
l-bat
force-pushed
the
ngraph
branch
2 times, most recently
from
4de90de
to
ca459d5
Compare
dkurt
reviewed
Nov 6, 2019
dkurt
reviewed
Nov 6, 2019
dkurt
reviewed
Nov 6, 2019
dkurt
reviewed
Nov 24, 2019
alalek
reviewed
Nov 27, 2019
alalek
reviewed
Nov 27, 2019
|
|
||
| #ifdef HAVE_DNN_NGRAPH | ||
| return initNgraph(nodes); | ||
| #endif // HAVE_DNN_NGRAPH | ||
| InferenceEngine::Builder::Layer ieLayer = InferenceEngine::Builder::ScaleShiftLayer(name); |
There was a problem hiding this comment.
How this can work without runtime check?
Please run tests locally.
alalek
reviewed
Nov 28, 2019
alalek
reviewed
Nov 28, 2019
| InferenceEngine::CNNNetReader reader; | ||
| reader.ReadNetwork(xml); | ||
| reader.ReadWeights(bin); | ||
|
|
||
| InferenceEngine::CNNNetwork ieNet = reader.getNetwork(); | ||
| #else | ||
| InferenceEngine::Core& ie = getCore(); | ||
| InferenceEngine::CNNNetwork ieNet = ie.ReadNetwork(xml, bin); |
There was a problem hiding this comment.
@dkurt Please review this part of code.
There was a problem hiding this comment.
We can, but CNNNetReader is almost deprecated.
alalek
reviewed
Nov 28, 2019
modules/dnn/src/ie_ngraph.cpp
Outdated
Comment on lines
217
to
218
| if (cnn.getPrecision() != InferenceEngine::Precision::FP16 && targetId == DNN_TARGET_MYRIAD) | ||
| resetMyriadDevice(); |
alalek
reviewed
Nov 28, 2019
| if (!equal_flag) | ||
| { | ||
| InferenceEngine::CNNNetwork curr_t_net(t_net); | ||
| curr_t_net.reshape(inShapes); |
There was a problem hiding this comment.
Why is ".get()" method with "const" logical modifier doing some network reshaping?
There was a problem hiding this comment.
It looks like a workaround introduced at #13608 to dynamically reshape networks from OpenVINO's IRs in case of different input shape.
dkurt
reviewed
Nov 29, 2019
dkurt
reviewed
Nov 30, 2019
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support new Inference Engine API.
Problem layers:
Failed nets:
⁉️ Test_Torch_nets.FastNeuralStyle_accuracy (DLDT)
✔️ DNNTestNetwork.MobileNet_SSD_Caffe_Different_Width_Height (bad norm)
✔️ DNNTestNetwork.OpenFace (bad norm) support Power
✔️ Test_Caffe_nets.FasterRCNN_zf (Proposal bug)
✔️ Test_TensorFlow_nets.opencv_face_detector_uint8 (blob not found) -> bad norm
✔️ Test_TensorFlow_nets.EAST_text_detection (maxpool incorrect shape + incorrect net) -> bad norm (support Power)
🔻 Test_Torch_nets.ENet_accuracy (bad norm)
✔️ Test_Torch_nets.OpenFace_accuracy (bad norm) support Power
❌ TEST_P(Test_Darknet_nets_async, Accuracy) (layer = nullptr sigseg Region doesn't supported)
After fuse:
✔️ Test_ONNX_nets.DenseNet121 (blob not found)
✔️ Test_Darknet_nets.YOLOv3 ( bad norm - DLDT)
✔️ Deconv3D fixed #15572
✔️ Eltwise with coeffs
✔️ Pooling (default ceil TF)
✔️ Scale (BatchNorm)
Link with IE nGraph:
🔻 Test_Caffe_nets.FasterRCNN_vgg16
✔️ Test_TensorFlow_nets.Faster_RCNN (topK DetectionOutput)