core(logger): add CV_LOG_ONCE_xxx() CV_LOG_IF_xxx() macros #16704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadimLevin
reviewed
Mar 2, 2020
| CV_LOG_VERBOSE(NULL, 0, "Verbose message: " << id); | ||
| CV_LOG_VERBOSE(NULL, 1, "Verbose message: " << id); | ||
| CV_LOG_DEBUG(NULL, "Debug message: " << id); | ||
| CV_LOG_INFO(NULL, "Info message: " << id); |
There was a problem hiding this comment.
Google Test framework has 2 helper function to capture output: testing::internal::CaptureStdout and testing::internal::CaptureStderr. I would like to suggest to use the following pattern to check that message actually was logged:
testing::internal::CaptureStdout();
CV_LOG_INFO(NULL, "Info message: " << id);
EXPECT_TRUE(testing::internal::GetCapturedStdout().find_first_of("Info message: 42") != std::string::npos);There was a problem hiding this comment.
Thank you for the suggestion.
Actually I want to keep these tests as disabled for now - check compilation only (and run them in manual mode if we have corresponding changes).
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added macros:
CV_LOG_ONCE_xxx(tag, ...message)CV_LOG_IF_xxx(tag, logging_condition, ...message)