-
-
Notifications
You must be signed in to change notification settings - Fork 55.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header parser explicit
constructors support
#17017
Header parser explicit
constructors support
#17017
Conversation
Issue is here because Java bindings tests don't cover VideoCapture constructor.
Validation of bindings generator changes can be performed by comparing generated code with and without the patch. Changes are reviewed manually. |
- It is safe to remove `explicit` keyword for constructors with 1 argument, because it is C++ specific keyword and does not affect any of the generated binding.
20226ff
to
1d8c73c
Compare
Constructors with Output Before:
Output after:
|
explicit
constructors support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Thank you 👍
Validated through generated code:
modules/java_bindings_generator
(ctors are restored)modules/python_bindings_generator
(no changes)
explicit
keyword is removed from the function declaration string.Resolves: #16988.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.