Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip some GAPI tests if VideoCapture is not capable to playback video #17471

Merged
merged 1 commit into from Jun 5, 2020

Conversation

asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented Jun 4, 2020

Relates to #17470

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@opencv-pushbot opencv-pushbot merged commit 434014b into opencv:master Jun 5, 2020
@dmatveev
Copy link
Contributor

Thanks! Should it be findDataFile(..., false) instead?

I also added an instruction on running tests, can you please check if it works for you? https://github.com/opencv/opencv/wiki/Graph-API

@asmorkalov
Copy link
Contributor Author

@dmatveev thanks for the instruction. The issue is related not to files search, but build configuration. FFmpeg and other video decoding back ends are not available during cross compilation. findDataFile can find file, but VideoCapture raises exception and test fails. I fixed only cases where VideoCapture is created in the test itself, but not hidden inside of G-API module.

@dmatveev
Copy link
Contributor

@asmorkalov got it now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants