-
-
Notifications
You must be signed in to change notification settings - Fork 55.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUDA: drop support of old CC #17478
CUDA: drop support of old CC #17478
Conversation
There are many aspects to discuss on this PR.
|
@tomoaki0705 Thanks for the started discussion you touched the same items that I want to bring. I discussed the proposal with @alalek and @vpisarev and outcome is the following: Key ideas
Technical proposal
|
Sorry for the late reply. |
80ff6e6
to
ba298d1
Compare
@asmorkalov , I've updated the PR. |
2e66ff4
to
9213671
Compare
* keep it possible to build for old CC * make sure old generations don't come up for the choice * remove related version check of old one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
resolves #16649
Still, this PR is open for discussion.
Supporting different CUDA based on branch is one solution.
Updating CUDA 8.0 is also another point to discuss.
It's still possible to build for old CC, by specifying
CUDA_ARCH_BIN
manually at cmake stagePull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.