Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G-API: Make GFrame a new (distinct) G-type, not an alias to GMat #18391

Merged
merged 2 commits into from Sep 23, 2020
Merged

G-API: Make GFrame a new (distinct) G-type, not an alias to GMat #18391

merged 2 commits into from Sep 23, 2020

Conversation

dmatveev
Copy link
Contributor

  • The underlying host type is still cv::Mat, a new cv::MediaFrame
    type is to be added as a separate PR.

  • I agree to contribute to the project under Apache 2 License.

  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV

  • The PR is proposed to proper branch

  • There is reference to original bug report and related work

  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.

  • The feature is well documented and sample code can be built with the project CMake

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2020.4.0:16.04
build_image:Custom Win=openvino-2020.4.0
build_image:Custom Mac=openvino-2020.4.0

test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@dmatveev
G-API: Make GFrame a new (distinct) G-type, not an alias to GMat
f573c37 
- The underlying host type is still cv::Mat, a new cv::MediaFrame
  type is to be added as a separate PR
@dmatveev dmatveev added this to the 4.5.0 milestone Sep 23, 2020
@TolyaTalamanov
Copy link
Contributor

Thanks! LGTM 👍

@dmatveev
Fix warnings and review comments
5854262 
- Somewhow there was a switch() without a default: clause in Fluid
@dmatveev
Copy link
Contributor Author

@alalek @mshabunin can we proceed with merge?

@smirnov-alexey
Copy link
Contributor

Looks good. Does it have to do something with the recently introduced RMat?

@dmatveev
Copy link
Contributor Author

Does it have to do something with the recently introduced RMat?

A common spirit, I believe. Nothing else :)

@alalek alalek merged commit e937d9b into opencv:master Sep 23, 2020
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@dmatveev
Merge pull request opencv#18391 from dmatveev:dm/gframe_00_new_type
0cb16a1 
* G-API: Make GFrame a new (distinct) G-type, not an alias to GMat

- The underlying host type is still cv::Mat, a new cv::MediaFrame
  type is to be added as a separate PR

* Fix warnings and review comments

- Somewhow there was a switch() without a default: clause in Fluid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TolyaTalamanov TolyaTalamanov TolyaTalamanov approved these changes

Assignees

@TolyaTalamanov TolyaTalamanov

Labels
category: g-api / gapi
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmatveev @TolyaTalamanov @smirnov-alexey @alalek