Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calib3d is split into 3d, calib and stereo #18915

Closed
wants to merge 12 commits into from
Closed

Conversation

vpisarev
Copy link
Contributor

@vpisarev vpisarev commented Nov 25, 2020

relates to #18267

At once, some of the old code has been finally ported from OpenCV 1.x C API to C++ API.
Note that this pull request is just beginning of 3D functionality refactoring. Probably, it's too radical in some places, e.g. cv::findHomography() is now spelled as cv3d::findHomography(), which may break a lot of users' code; probably, some of the most popular functionality from 3D, calib and stereo module should be exposed in cv namespace, not the nested namespaces.

There is satellite pull request in opencv_contrib:

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • [N/A] There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@vpisarev vpisarev mentioned this pull request Nov 25, 2020
4 tasks
@vpisarev
Copy link
Contributor Author

closed in favor of #18940

@vpisarev vpisarev closed this Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant