Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Min layer to CPU, OpenCL, Halide, Inference Engine, NGraph and CUDA #20682

Merged
merged 3 commits into from Sep 22, 2021

Conversation

rogday
Copy link
Member

@rogday rogday commented Sep 9, 2021

Merge with extra: opencv/opencv_extra#908

Related: #20438

opencv_extra=min

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2021.4.0:20.04
build_image:Custom Win=openvino-2021.4.0
build_image:Custom Mac=openvino-2021.4.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@rogday rogday marked this pull request as draft September 10, 2021 12:00
@alalek
Copy link
Member

alalek commented Sep 10, 2021

It make sense to create another PR to master branch as this PR to 3.4 is ready.
(which includes these changes or wait for "merge 3.4" PR (ETA: end of week))

@rogday rogday changed the title Add min layer to cpu, opencl, halide, inference engine and ngraph Add Min layer to CPU, OpenCL, Halide, Inference Engine, NGraph and CUDA Sep 10, 2021
@rogday rogday marked this pull request as ready for review September 10, 2021 14:58
@YashasSamaga
Copy link
Contributor

YashasSamaga commented Sep 12, 2021

Maybe fusions tests should be enabled for min op:

static testing::internal::ParamGenerator<std::string> eltwiseOpList()
{
// TODO: automate list generation
return Values("sum", "max", "prod", "div");
}

They might help identify accidental fusions.

Copy link

@sergei-sl sergei-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@sl-sergei sl-sergei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve from the correct account

@alalek alalek merged commit 38b9ec7 into opencv:master Sep 22, 2021
@rogday rogday deleted the min branch October 7, 2021 13:15
@alalek alalek mentioned this pull request Oct 15, 2021
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
* Add Min layer to CPU, OpenCL, Halide, Inference Engine, NGraph and CUDA

* fix indentation

* add min to fusion and halide tests; fix doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants