G-API: oneVPL (simplification) Add simple decode pipeline #20739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivanov-work
requested review from
dmatveev,
rgarnov,
AsyaPronina,
smirnov-alexey and
TolyaTalamanov
dmatveev
reviewed
Sep 23, 2021
| break; | ||
| case MFX_FOURCC_I010: | ||
| case MFX_FOURCC_P010: | ||
| nbytes = width * height + 2 * half_width * half_height; |
There was a problem hiding this comment.
Should this size in bytes include alignment?
In some platforms, image data (stride) is aligned to some multiplier and may exceed its logical size.
There was a problem hiding this comment.
no, without alignment.
could you please share some resources or provide some info how to deal with it?
There was a problem hiding this comment.
not sure, unfortunately. usually we learn about this limitations when enabling this or that particular platform. even more, on kmb one revision had one alignment and other revision has required the other.
At least I'd make it configurable somehow
modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.cpp
Outdated
Show resolved
Hide resolved
modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.cpp
Outdated
Show resolved
Hide resolved
modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.cpp
Show resolved
Hide resolved
modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.cpp
Outdated
Show resolved
Hide resolved
modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.hpp
Outdated
Show resolved
Hide resolved
modules/gapi/src/streaming/onevpl/engine/processing_engine_base.cpp
Outdated
Show resolved
Hide resolved
modules/gapi/src/streaming/onevpl/engine/processing_engine_base.cpp
Outdated
Show resolved
Hide resolved
sivanov-work
commented
Sep 24, 2021
| break; | ||
| case MFX_FOURCC_I010: | ||
| case MFX_FOURCC_P010: | ||
| nbytes = width * height + 2 * half_width * half_height; |
There was a problem hiding this comment.
no, without alignment.
could you please share some resources or provide some info how to deal with it?
modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.cpp
Outdated
Show resolved
Hide resolved
| ", offset: " << out_buf_ptr_offset << | ||
| ", W: " << surfW << | ||
| ", H: " << surfH); | ||
| GAPI_Assert(false && "Invalid offset"); |
There was a problem hiding this comment.
will throw exception too
modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.cpp
Outdated
Show resolved
Hide resolved
modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.cpp
Show resolved
Hide resolved
modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.cpp
Outdated
Show resolved
Hide resolved
modules/gapi/src/streaming/onevpl/engine/decode/decode_engine_legacy.hpp
Outdated
Show resolved
Hide resolved
modules/gapi/src/streaming/onevpl/engine/processing_engine_base.cpp
Outdated
Show resolved
Hide resolved
modules/gapi/src/streaming/onevpl/engine/processing_engine_base.cpp
Outdated
Show resolved
Hide resolved
modules/gapi/src/streaming/onevpl/engine/processing_engine_base.cpp
Outdated
Show resolved
Hide resolved
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
G-API: oneVPL (simplification) Add simple decode pipeline * Add simple decode pipeline & add onevpl namespace * Address some review comments * Add compilation guard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is the single one in series of #20469
Introduces simple decoding pipeline & related data structures
P.S. This pipeline flow would be improved for fully async-decode flow in the next PRs
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Build configuration