Extra imports and an environment for opencv-python package #21209
Conversation
|
IMO, we don't really need such downstream details in upstream repository. |
|
@alalek, do you mean we don't need to have it in opencv repository and we should add it in opencv-python repository? |
|
Yes, this specific code should be kept in |
|
|
||
| # hotfix for pylint issue (https://github.com/opencv/opencv-python/issues/570) | ||
| from . import getStructuringElement, MORPH_ELLIPSE | ||
|
|
||
| # extra imports for a proper autocomplete work in IDE | ||
| from . import _registerMatType | ||
| from . import gapi | ||
| from . import mat_wrapper | ||
| from . import misc | ||
| from . import utils |
There was a problem hiding this comment.
Okay. I would only suggest to keep it here, which fixes pylint issue (it even happens if to build opencv from the source) and allows to use modules (e.g. gapi, misc) using an autocomplete in IDE.
There was a problem hiding this comment.
Unfortunately pylint can't work with modern cv2 without manual own "brain" (like numpy) or plugin module (like django).
It doesn't see anything except import_module("cv2.cv2") line in opencv_python package. Neither sys.path changes, nor module symbols update.
| @@ -179,3 +179,13 @@ def load_first_config(fnames, required=True): | |||
|
|
|||
|
|
|||
| bootstrap() | |||
|
|
|||
| # hotfix for pylint issue (https://github.com/opencv/opencv-python/issues/570) | |||
| from . import getStructuringElement, MORPH_ELLIPSE | |||
There was a problem hiding this comment.
We definitely should not have that.
Issue provides a minimal reproducer. Do you want to add here other 100500 symbols?
/cc @asmorkalov
There was a problem hiding this comment.
I've seen a problem only with these two. We didn't have this issue when we had used an import of anything in a binary, e.g.
from .cv2 import *
I guess there was the import of the same modules if the issue has been disappeared.
| from . import getStructuringElement, MORPH_ELLIPSE | ||
|
|
||
| # extra imports for a proper autocomplete work in IDE | ||
| from . import _registerMatType |
There was a problem hiding this comment.
Users should not use private internal symbols directly.
There was a problem hiding this comment.
Yes, you're right, it shouldn't be here. I've just faced an error, when mat_wrapper module couldn't be imported w/o it. It's been when we have imported *.so file as cv2 module in opencv-python package.
Removed it.
| from . import gapi | ||
| from . import mat_wrapper | ||
| from . import misc | ||
| from . import utils |
There was a problem hiding this comment.
OpenCV has flexible module architecture (with custom set of modules), so such attempt of using hard-coded names just breaks the current design.
You can do that in opencv-python which uses fixed pre-defined build configuration, but it is not suitable for this upstream repository.
There was a problem hiding this comment.
I thought the idea was to keep one __init__.py file in opencv repository, and not to overwrite it in opencv-python repository. But okay, I'm closing this PR then.
This PR contains an extra environment from the script in opencv-python repository and extra imports which are defined after the
opencv-pythonpackage build.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.