-
-
Notifications
You must be signed in to change notification settings - Fork 55.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use YuNet of fixed input shape to fix not-supported-dynamic-zero-shape for FaceDetectorYN #21607
Use YuNet of fixed input shape to fix not-supported-dynamic-zero-shape for FaceDetectorYN #21607
Conversation
// FIXIT repair assertion | ||
// Disabled to pass face detector tests from #20422 | ||
// CV_Assert(!isDynamicShape); // not supported | ||
CV_Assert(!isDynamicShape); // not supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated detection model passes this assertion.
But recognition model doesn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem fixed. It was using before-update version of YuNet in the regression test of face recognition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
@alalek Do you have a plans to merge changes from 4.x branch into 5.x branch soon? |
…ynamic_shape Use YuNet of fixed input shape to fix not-supported-dynamic-zero-shape for FaceDetectorYN * use yunet with input of fixed shape * update yunet used in face recognition regression
Related bug report: #21340 (comment)
PR for opencv_extra: opencv/opencv_extra#958
If we are using YuNet of fixed input shape as the solution, the one in OpenCV Zoo will need to be updated as well.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.