Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing tolerance for Preproc4lpiTest set on ARM #22471

Merged
merged 1 commit into from Mar 24, 2023

Conversation

anna-khakimova
Copy link
Member

@anna-khakimova anna-khakimova commented Sep 4, 2022

The Resize gives calculation deviation on ARM. So the Resize test tolerance should be increased up to 2.
Fix for issue:
#19122

Xforce_builders=Linux AVX2,Linux32,Win32,Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
Xbuild_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2021.3.0:20.04
build_image:Custom Win=openvino-2021.4.1
build_image:Custom Mac=openvino-2021.2.0

buildworker:Custom Win=windows-3

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
Xtest_opencl:Custom=OFF
Xtest_bigdata:Custom=1
Xtest_filter:Custom=*

CPU_BASELINE:Custom Win=AVX512_SKX
CPU_BASELINE:Custom=SSE4_2

@anna-khakimova anna-khakimova changed the title Fix tolerance for Preproc4lpiTest set on ARM Increase tolerance for Preproc4lpiTest set on ARM Sep 4, 2022
@anna-khakimova anna-khakimova changed the title Increase tolerance for Preproc4lpiTest set on ARM Increasing tolerance for Preproc4lpiTest set on ARM Sep 4, 2022
@anna-khakimova anna-khakimova linked an issue Sep 4, 2022 that may be closed by this pull request
4 tasks
@dmatveev dmatveev self-assigned this Sep 15, 2022
@dmatveev dmatveev added this to the 4.7.0 milestone Sep 15, 2022
Copy link
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a comment in the test (explaining the accuracy difference on ARM) would help further generations a lot

modules/gapi/test/gapi_fluid_resize_test.cpp Show resolved Hide resolved
@asmorkalov
Copy link
Contributor

@dmatveev Should I merge the PR now, or you want to investigate x86 vs arm issue?

@dmatveev
Copy link
Contributor

dmatveev commented Oct 4, 2022

@asmorkalov you can merge if it helps (but as far as I know it doesn't). Waiting for @anna-khakimova to follow-up

@asmorkalov asmorkalov merged commit b56a52c into opencv:4.x Mar 24, 2023
18 checks passed
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subset of Fluid/Preproc4lpiTest.Test tests fails on arm64
4 participants