New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with VA_INCLUDE_HEADERS when building with CUDA support #22712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But I would recommend to add warning because vpl on Linux Is useless without va_api
modules/gapi/CMakeLists.txt
Outdated
endif(WITH_VA) | ||
if(UNIX AND HAVE_VA) | ||
ocv_target_include_directories(${the_module} SYSTEM PRIVATE ${VA_INCLUDE_DIR}) | ||
ocv_target_include_directories(opencv_test_gapi SYSTEM PRIVATE ${VA_INCLUDE_DIR}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opencv_test_gapi
Test target should be guarded, see code below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, updated. Thanks
Also tested the build with VA being available:
At least it builds now |
64f5e14
to
b619477
Compare
Perhaps it was designed like this for standalone G-API build. Do we still support this configuration? |
@mshabunin yes we do, but VPL & VAAPI were never a part of it. Good question if it is still tested on the CI though.. |
Issue description
WITH_
is used instead ofHAVE_
when checking for VA libs in G-API CMakeListsWITH_VA
isTRUE
by default on x86 (seeopencv/CMakeLists.txt:414
)WITH_VA
is still true and it is ok)OpenCVFindVA.cmake
as it is done anyway (seeopencv/CMakeLists.txt:743
andopencv/cmake/OpenCVFindLibsVideo.cmake
)Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.