Use QR code alignment markers #22891

AleksandrPanov · 2022-11-30T14:02:55Z

Added detect QR code alignment marker (1 marker for 2-6 versions, 6 markers for 7-40 versions). Alignment marker uses to find the correct position of the fourth corner.

To check the correctness, a benchmark was launched:
qr.py.txt

+2% total decode (~+5% against detected QR codes)
+0.4 pixels total accuracy for corner detect
Logging from benchmark:
METRIC_CORNER_DIST_default.txt
METRIC_CORNER_DIST_new.txt

No decode regression now.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

modules/objdetect/src/qrcode.cpp

asmorkalov · 2022-12-01T14:00:53Z

It makes sense to enable all disabled tests for QR codes first. Version estimation and alignment markers should make more tests stable.

modules/objdetect/src/qrcode.cpp

modules/objdetect/include/opencv2/objdetect.hpp

asmorkalov · 2022-12-12T15:28:16Z

@alalek May we merge the patch?

alalek

BTW,
There is opencv_extra patch related to this (it should be marked on the first visible line instead of somewhere in the middle of description).
Test data size is >600kB for one test image.

modules/objdetect/src/qrcode.cpp

alalek · 2022-12-13T04:58:10Z

modules/objdetect/test/test_qrcode.cpp

 std::string qrcode_images_multiple[] = {
-  "2_qrcodes.png", "3_close_qrcodes.png", "3_qrcodes.png", "4_qrcodes.png",
+  "2_qrcodes.png", /*"3_close_qrcodes.png",*/ "3_qrcodes.png", /*"4_qrcodes.png",*/
  "5_qrcodes.png", "6_qrcodes.png", "7_qrcodes.png", "8_close_qrcodes.png"
 };
+// 3_close_qrcodes.png, 4_qrcodes.png DISABLED after PR #22891


Some test cases are disabled (so it is formally a regression).

fixing regression

modules/objdetect/src/qrcode.cpp

alalek · 2022-12-13T05:05:20Z

modules/objdetect/test/test_qrcode.cpp

+
+    std::vector<Mat1b> straight_barcode;
+    qrcode.detectAndDecodeMulti(src, decoded_info, corners, straight_barcode);
+    EXPECT_EQ(decoded_info.size(), 9ull);


Again, wrong order.

AleksandrPanov · 2022-12-13T08:48:41Z

BTW, There is opencv_extra patch related to this (it should be marked on the first visible line instead of somewhere in the middle of description). Test data size is >600kB for one test image.

opencv_extra patch notes moved to first line, test image was scaled to 306.2 kB

There are 9 qr codes with big enough version in one test image (old test image 9_qrcodes.jpg has 290 kB size with low qrs version).

modules/objdetect/src/qrcode.cpp

AleksandrPanov · 2022-12-14T21:02:40Z

modules/objdetect/perf/perf_qrcode_pipeline.cpp

@@ -114,7 +114,6 @@ PERF_TEST_P_(Perf_Objdetect_QRCode_Multi, decodeMulti)
        straight_barcode_sort.push_back(result[i].second);
    }
    SANITY_CHECK(decoded_info_sort);
-    SANITY_CHECK(straight_barcode_sort);


Some problem in 4_qrcodes.png, 8_close_qrcodes.png
This QRs correctly decoded, but there is no bitwise equality in straight_barcode and golds. I think this is an optional check. A successful decode should mean that the test has passed.

alalek

Thank you 👍

AleksandrPanov added the category: objdetect label Nov 30, 2022

AleksandrPanov force-pushed the qr_add_alignment branch from f04b7f4 to ceb0ec7 Compare November 30, 2022 14:05

asmorkalov changed the title ~~add alignment detect~~ Use QR code alignment margkers Nov 30, 2022

asmorkalov changed the title ~~Use QR code alignment margkers~~ Use QR code alignment markers Nov 30, 2022

asmorkalov added the feature label Nov 30, 2022

AleksandrPanov force-pushed the qr_add_alignment branch from ceb0ec7 to 995f454 Compare December 1, 2022 09:12

asmorkalov reviewed Dec 1, 2022

View reviewed changes

AleksandrPanov force-pushed the qr_add_alignment branch 2 times, most recently from 429adcc to 72a1a1f Compare December 1, 2022 21:02

Samson-Mayeem approved these changes Dec 2, 2022

View reviewed changes

AleksandrPanov force-pushed the qr_add_alignment branch 3 times, most recently from 6f099ea to 171afaf Compare December 5, 2022 03:07

asmorkalov reviewed Dec 5, 2022

View reviewed changes

AleksandrPanov force-pushed the qr_add_alignment branch from df2ed38 to 7d9142c Compare December 5, 2022 08:51

asmorkalov marked this pull request as ready for review December 6, 2022 08:18

AleksandrPanov force-pushed the qr_add_alignment branch 2 times, most recently from 500a205 to c4a00da Compare December 6, 2022 19:40

asmorkalov added this to the 4.7.0 milestone Dec 7, 2022

AleksandrPanov force-pushed the qr_add_alignment branch from c4a00da to 48f8bf9 Compare December 7, 2022 23:27

asmorkalov reviewed Dec 8, 2022

View reviewed changes

modules/objdetect/include/opencv2/objdetect.hpp Outdated Show resolved Hide resolved

asmorkalov added the test label Dec 8, 2022

AleksandrPanov mentioned this pull request Dec 8, 2022

add 9 qr codes with 7 version opencv/opencv_extra#1024

Merged

AleksandrPanov force-pushed the qr_add_alignment branch 2 times, most recently from 177f5d2 to aca6f07 Compare December 8, 2022 19:49

asmorkalov approved these changes Dec 12, 2022

View reviewed changes

alalek reviewed Dec 13, 2022

View reviewed changes

AleksandrPanov force-pushed the qr_add_alignment branch 3 times, most recently from ec878b4 to cdc96b3 Compare December 13, 2022 18:22

asmorkalov reviewed Dec 14, 2022

View reviewed changes

modules/objdetect/src/qrcode.cpp Outdated Show resolved Hide resolved

modules/objdetect/src/qrcode.cpp Show resolved Hide resolved

AleksandrPanov force-pushed the qr_add_alignment branch from cdc96b3 to dbd9126 Compare December 14, 2022 18:22

add alignment detect

a321430

AleksandrPanov force-pushed the qr_add_alignment branch from dbd9126 to a321430 Compare December 14, 2022 20:58

AleksandrPanov commented Dec 14, 2022

View reviewed changes

alalek approved these changes Dec 14, 2022

View reviewed changes

asmorkalov merged commit 0153e79 into opencv:4.x Dec 15, 2022

alalek mentioned this pull request Jan 8, 2023

(5.x) Merge 4.x #23113

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use QR code alignment markers #22891

Use QR code alignment markers #22891

AleksandrPanov commented Nov 30, 2022 •

edited

asmorkalov commented Dec 1, 2022

asmorkalov commented Dec 12, 2022

alalek left a comment

alalek Dec 13, 2022

AleksandrPanov Dec 13, 2022

alalek Dec 13, 2022

AleksandrPanov Dec 13, 2022

AleksandrPanov commented Dec 13, 2022 •

edited

AleksandrPanov Dec 14, 2022 •

edited

alalek Dec 14, 2022

alalek left a comment

Use QR code alignment markers #22891

Use QR code alignment markers #22891

Conversation

AleksandrPanov commented Nov 30, 2022 • edited

Pull Request Readiness Checklist

asmorkalov commented Dec 1, 2022

asmorkalov commented Dec 12, 2022

alalek left a comment

Choose a reason for hiding this comment

alalek Dec 13, 2022

Choose a reason for hiding this comment

AleksandrPanov Dec 13, 2022

Choose a reason for hiding this comment

alalek Dec 13, 2022

Choose a reason for hiding this comment

AleksandrPanov Dec 13, 2022

Choose a reason for hiding this comment

AleksandrPanov commented Dec 13, 2022 • edited

AleksandrPanov Dec 14, 2022 • edited

Choose a reason for hiding this comment

alalek Dec 14, 2022

Choose a reason for hiding this comment

alalek left a comment

Choose a reason for hiding this comment

AleksandrPanov commented Nov 30, 2022 •

edited

AleksandrPanov commented Dec 13, 2022 •

edited

AleksandrPanov Dec 14, 2022 •

edited