Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move contrib charuco to main objdetect #22986
Move contrib charuco to main objdetect #22986
Changes from all commits
99d3bc7
319d71f
5be4c66
0b8e274
20f2f7e
56d17ff
0e56eee
f4041a2
dcd11e4
100cc55
2a024f5
3698915
8ed708e
f0284f0
f59e284
d5c9f8d
7d34efa
12e279c
dcee0a0
8db0926
06ae747
50e0fb4
ffe588f
1f214f2
cb3aa2f
0ed1de9
24bc756
c82d524
88e10ee
db2e081
68b6ec2
8cd2949
3f0a507
2fce006
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to touch it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fix the vars
h
/w
is setting num corners for CharucoBard (like in chessboard)After fix CharucoBoard create looks like this:
cv::aruco::CharucoBoard::create(mBoardSize.width + 1, mBoardSize.height + 1, capParams.charucoSquareLength,
capParams.charucoMarkerSize, mArucoDictionary);
mCapParams.boardSize = cv::Size(5, 7);
was fixed to support compatibility with old default parameters