imgcodecs: tiff: Support to encode for CV_32S with compression params #23433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a limitation that TIFF input/output with added depth must be 1 channel.It is not documented. Indirectly cvtColor() gives an error that unsupported depth is entered. This is a confusing error for imread/imwrite users. As a related work, 3/4 channel will be supported at this fix. |
asmorkalov
reviewed
Apr 2, 2023
asmorkalov
requested changes
Apr 6, 2023
- Replaced BGR/RGB data reordering implementation from copying from SRC to DST to using mixChannel(). - Defined an enum to represent Mat types as strings(e.g. CV_8UC1, CV_32FC2, ...) instead of numbers. - (For test) Changed the success/failure judgment of imdecode from dst.empty() to the return value of function.
asmorkalov
approved these changes
Apr 10, 2023
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
imgcodecs: tiff: Support to encode for CV_32S with compression params Fix opencv#23416 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23416
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.