Fix OBS Virtual Camera capture. #23460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottagofaster236
commented
Apr 5, 2023
| if (checkSingleByteFormat(VD->pAmMediaType->subtype) || (VD->pAmMediaType->subtype == MEDIASUBTYPE_Y16)) { | ||
| if (checkSingleByteFormat(VD->pAmMediaType->subtype) || | ||
| (VD->pAmMediaType->subtype == MEDIASUBTYPE_Y16 || VD->pAmMediaType->subtype == MEDIASUBTYPE_YUY2)) | ||
| { |
There was a problem hiding this comment.
Converting from YUY2 to BGR manually instead of using DirectShow helps with making the OBS Virtual Camera work. But I am not sure whether it is a bug in the OBS Virtual Camera or in cap_dhow.cpp.
|
@mshabunin Could you take a look and comment? |
opencv-alalek
approved these changes
Apr 6, 2023
This was referenced Apr 6, 2023
Merged
DeePingXian
added a commit
to DeePingXian/opencv
that referenced
this pull request
Aug 13, 2023
Streamlabs Desktop has the same issue in opencv#19746. This fixes it using opencv#23460 method.
5 tasks
LaurentBerger
pushed a commit
to LaurentBerger/opencv
that referenced
this pull request
Sep 8, 2023
Streamlabs Desktop has the same issue in opencv#19746. This fixes it using opencv#23460 method. Add getMatInblob function e
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
Streamlabs Desktop has the same issue in opencv#19746. This fixes it using opencv#23460 method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19746
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request