Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nary elementwise bug in cpu #23557

Merged
merged 1 commit into from May 11, 2023
Merged

Conversation

WanliZhong
Copy link
Member

@WanliZhong WanliZhong commented Apr 28, 2023

After fix this bug, the brute force test mentioned in #23556 will all passed in CPU.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.8.0 milestone Apr 28, 2023
@asmorkalov asmorkalov added the pr: needs test New functionality requires minimal tests set label May 1, 2023
@asmorkalov
Copy link
Contributor

@WanliZhong Please add the brute force test we disvussed offline on top of GTest.

@WanliZhong
Copy link
Member Author

WanliZhong commented May 1, 2023 via email

@WanliZhong
Copy link
Member Author

I make this brute force test disabled as default.

modules/dnn/test/test_layers.cpp Outdated Show resolved Hide resolved
modules/dnn/test/test_layers.cpp Outdated Show resolved Hide resolved
@asmorkalov asmorkalov requested review from dkurt and removed request for rogday May 5, 2023 11:07
@WanliZhong WanliZhong force-pushed the eltwise_cpu_bug branch 2 times, most recently from 95538ae to c4e8fbb Compare May 8, 2023 14:00
Copy link
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@zihaomu zihaomu added test and removed pr: needs test New functionality requires minimal tests set labels May 11, 2023
@WanliZhong
Copy link
Member Author

Test results is here. Run ./opencv_test_dnn --gtest_filter="Layer_Test_Eltwise_bcast.*/*" --gtest_also_run_disabled_tests
image

@asmorkalov asmorkalov merged commit 85b04f0 into opencv:4.x May 11, 2023
19 checks passed
@WanliZhong WanliZhong deleted the eltwise_cpu_bug branch May 16, 2023 12:33
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants