New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nary elementwise bug in cpu #23557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@WanliZhong Please add the brute force test we disvussed offline on top of GTest. |
I don't have my computer with me. I will update it after the holiday
|
WanliZhong
force-pushed
the
eltwise_cpu_bug
branch
from
May 5, 2023 09:04
9324b36
to
5947f8b
Compare
I make this brute force test disabled as default. |
asmorkalov
requested changes
May 5, 2023
dkurt
reviewed
May 5, 2023
WanliZhong
force-pushed
the
eltwise_cpu_bug
branch
2 times, most recently
from
May 8, 2023 14:00
95538ae
to
c4e8fbb
Compare
dkurt
reviewed
May 10, 2023
WanliZhong
force-pushed
the
eltwise_cpu_bug
branch
from
May 10, 2023 06:30
c4e8fbb
to
85cc408
Compare
dkurt
approved these changes
May 10, 2023
6 tasks
zihaomu
approved these changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
zihaomu
added
test
and removed
pr: needs test
New functionality requires minimal tests set
labels
May 11, 2023
asmorkalov
approved these changes
May 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fix this bug, the brute force test mentioned in #23556 will all passed in CPU.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.