G-API: Expose explicit preprocessing for IE Backend #23786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TolyaTalamanov
force-pushed
the
at/expose-preprocessing-to-ie-backend
branch
from
8fc145a
to
4392782
Compare
TolyaTalamanov
commented
Jun 12, 2023
| will be applied to all input layers. | ||
| @return reference to this parameter structure. | ||
| */ | ||
| Params<Net>& cfgInputLayout(std::string layout) { |
There was a problem hiding this comment.
Won't be exposed to python because IE backend is going to be deprecated soon...
| const cv::gapi::ie::TraitAs hint, | ||
| const IE::Layout layout) { | ||
| const auto &sz = mat.size; | ||
| if (sz.dims() == 2 && hint == cv::gapi::ie::TraitAs::IMAGE) |
There was a problem hiding this comment.
sz.dims() == 2 is not even needed there (Image by design 2d) but it also used from our tests
| cv::util::optional<cv::Rect>{}); | ||
| std::cout << std::endl; |
| @@ -1301,6 +1452,13 @@ static void configureOutputPrecision(const IE::OutputsDataMap &outputs | |||
| ); | |||
| } | |||
|
|
|||
| static void configureOutputLayout(const IE::OutputsDataMap &outputs_info, | |||
There was a problem hiding this comment.
Maybe it's not even worth a separate function...
dmatveev
approved these changes
Jun 12, 2023
Co-authored-by: Dmitry Matveev <dmm1989@gmail.com>
|
@asmorkalov is there any chance to merge it? |
TolyaTalamanov
changed the title
|
requires a little fix, moved to WIP so far... |
TolyaTalamanov
changed the title
TolyaTalamanov
changed the title
Done |
dmatveev
approved these changes
Jun 14, 2023
|
Yes, please merge |
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
…essing-to-ie-backend G-API: Expose explicit preprocessing for IE Backend opencv#23786 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [ ] I agree to contribute to the project under Apache 2 License. - [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.